Remove linear gradient tranfsorms from codec (#28)

* Remove linear gradient tranfsorms from codec

* fix radial gradient with no matrix

Author: dnfield

packages/vector_graphics/lib/src/listener.dart

@@ -186,7 +186,6 @@ class FlutterVectorGraphicsListener extends VectorGraphicsCodecListener {
     double toY,
     Int32List colors,
     Float32List? offsets,
-    Float64List? transform,
     int tileMode,
     int id,
   ) {
@@ -203,7 +202,6 @@ class FlutterVectorGraphicsListener extends VectorGraphicsCodecListener {
       colorValues,
       offsets,
       ui.TileMode.values[tileMode],
-      transform,
     );
     _shaders.add(gradient);
   }

packages/vector_graphics_codec/lib/vector_graphics_codec.dart

@@ -211,10 +211,8 @@ class VectorGraphicsCodec {
     required double toY,
     required Int32List colors,
     required Float32List? offsets,
-    required Float64List? transform,
     required int tileMode,
   }) {
-    assert(transform == null || transform.length == 16);
     if (buffer._decodePhase.index > _CurrentSection.shaders.index) {
       throw StateError('Shaders must be encoded together.');
     }
@@ -234,12 +232,6 @@ class VectorGraphicsCodec {
       buffer._putInt32(offsets.length);
       buffer._putFloat32List(offsets);
     }
-    if (transform != null) {
-      buffer._putUint8(transform.length);
-      buffer._putFloat64List(transform);
-    } else {
-      buffer._putInt32(0);
-    }
     buffer._putUint8(tileMode);
     return shaderId;
   }
@@ -292,7 +284,7 @@ class VectorGraphicsCodec {
       buffer._putUint8(transform.length);
       buffer._putFloat64List(transform);
     } else {
-      buffer._putInt32(0);
+      buffer._putUint8(0);
     }
     buffer._putUint8(tileMode);
     return shaderId;
@@ -345,9 +337,6 @@ class VectorGraphicsCodec {
     final Int32List colors = buffer.getInt32List(colorLength);
     final int offsetLength = buffer.getInt32();
     final Float32List offsets = buffer.getFloat32List(offsetLength);
-    final int transformLength = buffer.getUint8();
-    final Float64List? transform =
-        transformLength != 0 ? buffer.getFloat64List(transformLength) : null;
     final int tileMode = buffer.getUint8();
     listener?.onLinearGradient(
       fromX,
@@ -356,7 +345,6 @@ class VectorGraphicsCodec {
       toY,
       colors,
       offsets,
-      transform,
       tileMode,
       id,
     );
@@ -721,7 +709,6 @@ abstract class VectorGraphicsCodecListener {
     double toY,
     Int32List colors,
     Float32List? offsets,
-    Float64List? transform,
     int tileMode,
     int id,
   );

packages/vector_graphics_codec/test/vector_graphics_codec_test.dart

@@ -251,6 +251,41 @@ void main() {
     ]);
   });
 
+  test('Can encode a radial gradient (no matrix)', () {
+    final buffer = VectorGraphicsBuffer();
+    final TestListener listener = TestListener();
+
+    final int shaderId = codec.writeRadialGradient(
+      buffer,
+      centerX: 2.0,
+      centerY: 3.0,
+      radius: 5.0,
+      focalX: 1.0,
+      focalY: 1.0,
+      colors: Int32List.fromList([0xFFAABBAA]),
+      offsets: Float32List.fromList([2.2, 1.2]),
+      tileMode: 0,
+      transform: null,
+    );
+
+    codec.decode(buffer.done(), listener);
+
+    expect(listener.commands, [
+      OnRadialGradient(
+        centerX: 2.0,
+        centerY: 3.0,
+        radius: 5.0,
+        focalX: 1.0,
+        focalY: 1.0,
+        colors: Int32List.fromList([0xFFAABBAA]),
+        offsets: Float32List.fromList([2.2, 1.2]),
+        transform: null,
+        tileMode: 0,
+        id: shaderId,
+      ),
+    ]);
+  });
+
   test('Can encode a linear gradient', () {
     final buffer = VectorGraphicsBuffer();
     final TestListener listener = TestListener();
@@ -264,7 +299,6 @@ void main() {
       colors: Int32List.fromList([0xFFAABBAA]),
       offsets: Float32List.fromList([2.2, 1.2]),
       tileMode: 0,
-      transform: mat4,
     );
 
     codec.decode(buffer.done(), listener);
@@ -277,7 +311,6 @@ void main() {
         toY: 1.0,
         colors: Int32List.fromList([0xFFAABBAA]),
         offsets: Float32List.fromList([2.2, 1.2]),
-        transform: mat4,
         tileMode: 0,
         id: shaderId,
       ),
@@ -465,7 +498,6 @@ class TestListener extends VectorGraphicsCodecListener {
     double toY,
     Int32List colors,
     Float32List? offsets,
-    Float64List? transform,
     int tileMode,
     int id,
   ) {
@@ -476,7 +508,6 @@ class TestListener extends VectorGraphicsCodecListener {
       toY: toY,
       colors: colors,
       offsets: offsets,
-      transform: transform,
       tileMode: tileMode,
       id: id,
     ));
@@ -500,7 +531,6 @@ class OnLinearGradient {
     required this.toY,
     required this.colors,
     required this.offsets,
-    required this.transform,
     required this.tileMode,
     required this.id,
   });
@@ -511,7 +541,6 @@ class OnLinearGradient {
   final double toY;
   final Int32List colors;
   final Float32List? offsets;
-  final Float64List? transform;
   final int tileMode;
   final int id;
 
@@ -523,7 +552,6 @@ class OnLinearGradient {
         toY,
         Object.hashAll(colors),
         Object.hashAll(offsets ?? []),
-        Object.hashAll(transform ?? []),
         tileMode,
         id,
       );
@@ -537,7 +565,6 @@ class OnLinearGradient {
         other.toY == toY &&
         _listEquals(other.colors, colors) &&
         _listEquals(other.offsets, offsets) &&
-        _listEquals(other.transform, transform) &&
         other.tileMode == tileMode &&
         other.id == id;
   }

packages/vector_graphics_compiler/lib/vector_graphics_compiler.dart

@@ -68,7 +68,6 @@ Future<Uint8List> encodeSvg(String input, String filename) async {
             ? Float32List.fromList(shader.offsets!)
             : null,
         tileMode: shader.tileMode.index,
-        transform: _encodeMatrix(shader.transform),
       );
     } else if (shader is RadialGradient) {
       shaderId = codec.writeRadialGradient(