[Bug]: Cannot navigate between duplicate videos in playlist

[kommunarr]

Guidelines

• I have encountered this bug in the latest release of FreeTube.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.
• I have searched the documentation for information that matches the description of the bug I want to file, without success.

Describe the bug

1. Save the same video twice to the same playlist
2. Open that video in the playlist from the Playlist tab
3. Try to click on duplicate video entry: encounter bug
4. Try to click on "Play next video" button: encounter bug
5. Skip to end of video and try to let video autoplay: encounter bug

Expected Behavior

The duplicate video can be navigated to normally in any case.

Dev notes:
I would reckon this is happening because the videos have the same route. If that's the case, you'll have to add some dupe differentiator to the route (e.g., &duplicate-count={number}).

Issue Labels

usability issue

FreeTube Version

402af7a

Operating System Version

OpenSUSE Tumbleweed

Installation Method

other

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

• I have encountered this bug in the latest nightly build.

[PikachuEXE]

Fixed in 6e7a627

[kommunarr]

While this appears to be fixed for created playlists, I am still encountering the issue with the Favorites playlist.

Edit: It worked once, but now I'm still encountering it on created playlists. The bug is "fixed" in that you can try to navigate to a duplicate if you select the first duplicate in the playlist. But then the UI shows that the first duplicate is still the active playlist video, and you can't navigate to the other duplicates anymore. Tested with a playlist comprised of one video duplicated three times.

[PikachuEXE]

I have only fixed the clicking on links in 6e7a627

Please confirm if it's fixed or not first

I will try to take a look at Play next video which needs more changes (and probably more complicated)

[kommunarr]

To clarify, I'm still experiencing the issue when clicking on links in the watch-video-playlist box.

[PikachuEXE]

Cannot reproduce

Videos:

• https://youtu.be/qAE5KoyFEUo
• https://youtu.be/jJlfOhQ_f1M

Even I just create another new playlist now with duplicate I have no issue

Not to mention I might have also fixed play next/prev video in 66e3dbe

Might need help from @efb4f5ff-1298-471a-8973-3d47447115dc

[efb4f5ff-1298-471a-8973-3d47447115dc]

ave the same video twice to the same playlist
Open that video in the playlist from the Playlist tab
Try to click on duplicate video entry: encounter bug

Did not get a bug but on clicking on nr 4 it went to play nr 4 so i thought but i actually just reloaded nr 3

Try to click on "Play next video" button: encounter bug

When i got to this step it actually played nr 4

Skip to end of video and try to let video autoplay: encounter bug

no error here

[PikachuEXE]

Did not get a bug but on clicking on nr 4 it went to play nr 4 so i thought but i actually just reloaded nr 3

In watch page? or from local playlist view (inside a playlist)? or something else

Let me test both tomorrow

[efb4f5ff-1298-471a-8973-3d47447115dc]

This is on the watch page

[PikachuEXE]

I have tried both (from single local playlist view) & watch page on a playlist with duplicate videos
I clicked on non 1st video (2nd/3rd) and also 1st video to compare the results

The playlist component is showing correct entry being played

So for me it's cannot be reproduced anymore (after fix)

[efb4f5ff-1298-471a-8973-3d47447115dc]

Still get the bug im on bdb2a94

VirtualBoxVM_0r1JaOEYXv.mp4

[PikachuEXE]

OK I see what's wrong
The URLs in different links are different
Fixing...

[PikachuEXE]

Fixed in 25c75ce

[efb4f5ff-1298-471a-8973-3d47447115dc]

Can confirm that its fixed. Just to confirm @jasonhenriquez did u experience the same as me when it didn't work or is there still something that needs to be addressed?

[efb4f5ff-1298-471a-8973-3d47447115dc]

@jasonhenriquez @jasonhenriquez @jasonhenriquez @jasonhenriquez @jasonhenriquez

[kommunarr]

Got this error while moving a duplicate video up in a playlist using the arrow button. But otherwise, looks good

[PikachuEXE]

I think that's one of the callback errors from player after you switch back from watch video view
Please try it without watching any video

[efb4f5ff-1298-471a-8973-3d47447115dc]

can be closed btw