Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking only visible text/current page/current node/current section? #2

Closed
ghost opened this issue May 28, 2021 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented May 28, 2021

Hello and a HUGE thank you for this great plug-in.

I have enjoyed it immensely, it is a giant help to people writing in Emacs.

I would like, though, to ask for a feature, if possible.

At the moment, the "automatic" checking mode, languagetool-server-mode, works on the whole buffer.
This is usually not required (although, I believe, there are checks that only work globally.), and is very resource-intensive.

Would it be possible to add an option to restrict server-mode checking to the visible text, perhaps launched automatically after a short period of inactivity, say, 2 seconds?

The authors of spell-fu https://gitlab.com/ideasman42/emacs-spell-fu implement this somehow, as an alternative to flyspell mode.

@PillFall
Copy link
Owner

Hello!

I kept that in mind when creating this plug-in, and it should only check the current accessible portion of the buffer, even when it's narrowed. Yet it have to wide it to clear all the previous suggestions in case of any.

I'll check that out, cause I know that the current system has a really poor performance. I'm trying to replicate flyspell behaviour (I didn't know about spell-fu, I'll take a look).

And yes. I think that would be a great idea. I would implement that these days. (In the begining I have implemented that way, But was a mess. 😂)

@PillFall PillFall self-assigned this May 31, 2021
@PillFall PillFall added the enhancement New feature or request label May 31, 2021
@PillFall
Copy link
Owner

This now should be a bit more better than before. And it has now implemented a timer in a similar way spell-fu does. Hope this help. Please let me know if something is broken ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant