Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate FASTJSON2 vs Gson for property de-/serialization #920

Open
PimvanderLoos opened this issue Nov 6, 2024 · 0 comments
Open

Investigate FASTJSON2 vs Gson for property de-/serialization #920

PimvanderLoos opened this issue Nov 6, 2024 · 0 comments
Assignees

Comments

@PimvanderLoos
Copy link
Owner

PimvanderLoos commented Nov 6, 2024

The current property setup uses FASTJSON2 for de-/serialization of property values.

Initially, FASTJSON2 was selected because it was faster and purely used internally. However, given that we now expose (parts of) our serialization system to external plugins, we should re-evaluate whether this is still the right library for us.

Serialization performance is no longer the primary factor, as it should also be easy to use for external plugins.

While FASTJSON2 is pretty easy to use overall, it has two significant disadvantages:

  1. The general Minecraft plugin ecosystem uses Gson as it is packaged with Spigot by default.
  2. FASTJSON2's documentation is awful and there is a severe lack of examples available, which isn't the case for Gson.

This is a follow-up to PR #896

@PimvanderLoos PimvanderLoos self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant