Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and convert to subdomain URL's #3

Closed
dokterbob opened this issue Aug 1, 2021 · 2 comments
Closed

Detect and convert to subdomain URL's #3

dokterbob opened this issue Aug 1, 2021 · 2 comments
Labels
bug Something isn't working P:0 High priority security

Comments

@dokterbob
Copy link

Gateway URL's should be transformed to <root_cid>.ipfs.gatewaydomain instead of using /ipfs/ or /ipns otherwise all IPFS resources share the same security context!

This is a big security concern!

Background: https://consensys.net/diligence/blog/2021/06/ipfs-gateway-security/
@dokterbob
Copy link
Author

Ref: ipfs/in-web-browsers#89

@starryeyez024 starryeyez024 added bug Something isn't working security P:0 High priority labels Apr 5, 2022
@polluterofminds
Copy link
Contributor

I believe this is resolved with this commit: 18b9b1e

Heads up though, this did introduce a bug where full path filenames aren't working (i.e. ipfs/CID/myfile.png). There's a bug open and we'll hopefully have a fix for that soon. #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P:0 High priority security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dokterbob @starryeyez024 @polluterofminds