Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensor is not respecting it's given name #13

Closed
pejotigrek opened this issue Nov 4, 2021 · 4 comments · Fixed by #20
Closed

sensor is not respecting it's given name #13

pejotigrek opened this issue Nov 4, 2021 · 4 comments · Fixed by #20
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@pejotigrek
Copy link

not a major bug, but my OCD can't unsee it ;)
as I'm always trying to set up names "my way" for sorting/filtering purposes, I gave new names to binary_sensor and sensor:

binary_sensor:
- platform: antistorm
  name: 0_wth
  station_id: 275
  monitored_conditions:
  - 'storm_alarm'
  - 'rain_alarm'
  - 'storm_active'

sensor:
- platform: antistorm
  name: 0_wth
  station_id: 275
  monitored_conditions:
  - 'storm_probability'
  - 'storm_time'
  - 'rain_probability'
  - 'rain_time'

binary_sensor works fine and produces: binary_sensor.0_wth_275_rain_alarm, binary_sensor.0_wth_275_storm_active, binary_sensor.0_wth_275_storm_alarm, but sensor still creates it's own sensor.antistorm_275_rain_probability, sensor.antistorm_275_rain_time, sensor.antistorm_275_rain_time, sensor.antistorm_275_storm_time.

@PiotrMachowski
Copy link
Owner

Absolutely understandable :D

@PiotrMachowski PiotrMachowski self-assigned this Nov 4, 2021
@PiotrMachowski PiotrMachowski added bug Something isn't working enhancement New feature or request labels Nov 4, 2021
@pejotigrek
Copy link
Author

pejotigrek commented Nov 4, 2021

I'm thinking right now that it might be a breaking change for some people ;)

@PiotrMachowski
Copy link
Owner

It won't if I will add a config flow ;)

@PiotrMachowski PiotrMachowski linked a pull request Feb 8, 2024 that will close this issue
@PiotrMachowski
Copy link
Owner

Fixed in v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants