Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room cleaning ignores repeat count #294

Closed
3 tasks done
mateuszmalek opened this issue Jan 7, 2022 · 7 comments
Closed
3 tasks done

Room cleaning ignores repeat count #294

mateuszmalek opened this issue Jan 7, 2022 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@mateuszmalek
Copy link

Checklist

  • I have updated the card to the latest version available
  • I have cleared the cache of my browser
  • I have checked if the problem is already reported

The problem

It seems that room cleaning function is ignoring the repeat counter which was added in v2.0.9 (I believe within #256).
Setting 2 or 3 has the same result - vacuum cleans the room only once and returns to dock.

What version of a card has described problem?

v2.0.9

What was the last working version card?

No response

What vacuum model do you have problems with?

roborock.vacuum.s5e

Which integration do you use to control your vacuum (link)?

default

What browser (browsers/apps) does have this problem?

Chrome 97.0.4692.71

What version of Home Assistant do you use?

2021.12.8

What type of installation are you running?

Home Assistant OS

Card's configuration

type: custom:xiaomi-vacuum-map-card
map_source:
  camera: camera.xiaomi_cloud_map_extractor
  crop:
    top: 175
    left: 175
    right: 175
    bottom: 175
calibration_source:
  camera: true
entity: vacuum.roborock_vacuum_s5e
vacuum_platform: default
title: ''
map_locked: true
two_finger_pan: true
map_modes:
  - template: vacuum_clean_segment
    predefined_selections:
      - id: 16
        outline:
          - - 25146
            - 26101
          - - 28049
            - 26101
          - - 28007
            - 22651
          - - 25146
            - 22651
        icon:
          label: Bedroom
          name: mdi:bed
          x: 26534
          'y': 24671
      - id: 17
        outline:
          - - 28160
            - 28463
          - - 29579
            - 28463
          - - 29579
            - 26128
          - - 28160
            - 26128
        icon:
          name: mdi:shoe-sneaker
          x: 28801
          'y': 27181
      - id: 18
        outline:
          - - 30266
            - 25990
          - - 35258
            - 25990
          - - 35258
            - 22510
          - - 30266
            - 22510
        icon:
          x: 32785
          'y': 24296
          name: mdi:television
      - id: 19
        outline:
          - - 28114
            - 24479
          - - 29625
            - 24479
          - - 29625
            - 23242
          - - 28114
            - 23242
        icon:
          x: 28801
          'y': 23975
          name: mdi:shower
      - id: 20
        outline:
          - - 25091
            - 28005
          - - 28068
            - 28005
          - - 28068
            - 26860
          - - 25091
            - 26860
        icon:
          x: 26603
          'y': 27410
          name: mdi:countertop
      - id: 21
        outline:
          - - 28114
            - 26082
          - - 30146
            - 26082
          - - 30146
            - 24571
          - - 28114
            - 24571
        icon:
          x: 29030
          'y': 25212
          name: mdi:book-open-page-variant
  - template: vacuum_clean_zone
  - template: vacuum_goto

Javascript errors shown in the browser's console (if applicable)

No response

Additional information

No response

@mateuszmalek mateuszmalek added the bug Something isn't working label Jan 7, 2022
@mateuszmalek
Copy link
Author

I've tried to fix it myself but I believe it's an issue with integration instead: home-assistant/core#59110

Manually triggering command results in the same behavior.

service: xiaomi_miio.vacuum_clean_segment
data:
  segments:
    - 21
    - 21
target:
  entity_id: vacuum.roborock_vacuum_s5e

@PiotrMachowski
Copy link
Owner

Well, I can't do much in this case

@mateuszmalek
Copy link
Author

After some troubleshooting got it to work but still - I believe that's an upstream issue: home-assistant/core#59110 (comment) with xiaomi_miio.vacuum_clean_segment

@PiotrMachowski
Copy link
Owner

@mateuszmalek I think that it depends on vacuum model

@mateuszmalek
Copy link
Author

You're right probably :)

I was successfully able to make it work for my S5 Max by overriding default template:

  - template: vacuum_clean_segment
    repeats_type: EXTERNAL
    max_repeats: 3
    service_call_schema:
      service: vacuum.send_command
      service_data:
        command: app_segment_clean
        entity_id: '[[entity_id]]'
        params:
          - segments: '[[selection]]'
            repeat: '[[repeats]]'
    predefined_selections:
    (...)

Dzięki :)

@MMouse23
Copy link

MMouse23 commented May 16, 2023

You're right probably :)

I was successfully able to make it work for my S5 Max by overriding default template:

  - template: vacuum_clean_segment
    repeats_type: EXTERNAL
    max_repeats: 3
    service_call_schema:
      service: vacuum.send_command
      service_data:
        command: app_segment_clean
        entity_id: '[[entity_id]]'
        params:
          - segments: '[[selection]]'
            repeat: '[[repeats]]'
    predefined_selections:
    (...)

Dzięki :)

Can you show me a bit more how?
Where can i find that template

@PiotrMachowski
Copy link
Owner

@MMouse23 download the latest beta version of the card, it contains the fixed template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants