Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextBox wishlist #342

Closed
dcampbell24 opened this issue Mar 28, 2015 · 12 comments
Closed

TextBox wishlist #342

dcampbell24 opened this issue Mar 28, 2015 · 12 comments

Comments

@dcampbell24
Copy link
Member

The textbox widget is currently very simple and would be a lot more useful if it supported a set of features that would allow it to be used in a basic chat server. Major features that would be nice to have include:

  • multi-line
  • read only
  • highlight / copy and paste
  • Input Method Editor support

I am guessing adding support for the first two should be fairly straight-forward, but the last two may not be. The read only feature is related to #341 since it means updating the text box programatically is an error.

@mitchmindtree
Copy link
Contributor

Related #71, #62

@mitchmindtree
Copy link
Contributor

Agreed on this, TextBox is certainly a WIP and could use some love 😄

Highlight copy/paste would be a great next feature (once the bugs are addressed heh)! As for multi-line functionality, perhaps we could separate that into a TextArea widget? I remember thinking this might be a good idea, but I've forgotten why.

Anyway, I'm planning on starting a synth editor repo soon that will have me diving back into conrod, so I should be able to help out soon 👍

@dcampbell24
Copy link
Member Author

OK, great! I'm working on a networked Hearts game and building out the client GUI right now. I am going to spend a little time putting together the table display, then come back to these issues to get chat working.

@dcampbell24
Copy link
Member Author

Related #205

@LaylBongers
Copy link

When I get to adding copypaste functionality to phosphorus, I'll make the cross platform functions for interaction with the clipboard available as a crate so it can be used in conrod.

@bvssvni
Copy link
Member

bvssvni commented Apr 24, 2015

@LaylConway That would be useful!

@mitchmindtree mitchmindtree modified the milestone: 1.0.0 Jul 11, 2015
@jdm
Copy link

jdm commented Aug 26, 2015

With regards to the clipboard, please see https://github.com/aweinstock314/rust-clipboard/ .

@mitchmindtree
Copy link
Contributor

@jdm thanks, looks good!

@psFried
Copy link
Contributor

psFried commented Oct 23, 2015

I'd like to add another feature to this discussion. What about the ability to tab between TextBoxes?

@mitchmindtree to your earlier point about having a separate TextArea widget, I think this is one of the differences. A TextBox would be suited for quickly entering small amounts of text into many small TextBoxes, so you would want to be able to quickly tab between them. A TextArea would be more like a mini text editor. IMO, you wouldn't want tab/enter to automatically move you to the next input field when you're in a TextArea, you'd want it to insert a literal tab/newline character.

@andresv
Copy link

andresv commented Feb 13, 2016

What about setting text color, there are color and frame_color : http://docs.piston.rs/conrod/conrod/struct.TextBox.html, but nothing for text_color.
I can see that there is also TextBoxStyle, however TextBox does not have public constructor that takes style. Some other widgets has styled method that can be used for this. For example rectangle has it: http://docs.piston.rs/conrod/conrod/struct.Rectangle.html

@mitchmindtree
Copy link
Contributor

I'm going to close this as most of this has since been implemented:

The Text widget allows for multi-line, read-only text supporting left, centre and right justification along with options for wrapping by word, character or not at all.

TextEdit is basically a wrapper around Text that allows for mutation and text selection.

TextBox has been updated to use TextEdit internally, and is basically a constrained version of the TextEdit on top of a BorderedRectangle.

Remaining features discussed here that are not yet satisfied can be added to the pre-existing #71.

@io12
Copy link

io12 commented Jan 19, 2019

Copy/paste support is still unimplemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants