Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The New Event-Based User Input System - TODO and bug-fixes #700

Closed
2 of 13 tasks
mitchmindtree opened this issue Feb 23, 2016 · 3 comments
Closed
2 of 13 tasks

The New Event-Based User Input System - TODO and bug-fixes #700

mitchmindtree opened this issue Feb 23, 2016 · 3 comments

Comments

@mitchmindtree
Copy link
Contributor

NOTE: Issue closed in favour of tracking progress at #703

This is a follow up of changes that are yet to be made following the implementation of conrod's new event-based user input system in #684 as discussed in #670.

Widgets that still need to be changed over to the new system:

  • Button
  • DropDownList
  • EnvelopeEditor
  • NumberDialer
  • Slider
  • Tabs (maybe?)
  • TextBox
  • TitleBar
  • Toggle
  • XYPad
  • CircularButton (from custom_widget.rs example)

Other related todo:

  • Review the Widget::drag_area method and related types and see if these can be removed in favour of using the new Drag events.
  • Fix bug where widgets still receive Clicked events when covered by another widget (should be using Graph::pick_widget method).
@mitchmindtree
Copy link
Contributor Author

@psFried I'm currently working away on the above and I noticed that we're creating drag events upon raw release events - I'm thinking of refactoring this to only generate drag events on raw move events as this feels a little more intuitive to me, but I'm curious to hear what your thoughts are on this first?

@mitchmindtree
Copy link
Contributor Author

Ahh, I just noticed the in_progress field in the MouseDrag struct.

How about rather than combining state into the one MouseDrag event, we add DragStart and DragEnd events?

Also, I'm thinking of changing MouseDrag -> Drag and MouseClick -> Click, thoughts?

@mitchmindtree
Copy link
Contributor Author

Going to close this issue in favour of tracking progress at #703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant