Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo fmt, Clippy, deprecation #49

Closed
Schuwi opened this issue Jun 13, 2020 · 3 comments
Closed

Cargo fmt, Clippy, deprecation #49

Schuwi opened this issue Jun 13, 2020 · 3 comments

Comments

@Schuwi
Copy link
Contributor

Schuwi commented Jun 13, 2020

When compiling the project rustc emits a lot of warnings. Also the code format seems inconsistent with cargo fmt.
I would suggest running cargo fmt, cargo clippy and fixing the deprecated stuff.

I might get on this myself in the next few days. Just wanted to hear if there is any reason that speaks against this :)

@atheriel
Copy link
Collaborator

Don’t rush to do a cargo fmt run, since it has some drawbacks preserving git history. But I’d be happy to see deprecation warnings and other clippy lints fixed.

@Schuwi
Copy link
Contributor Author

Schuwi commented Jun 14, 2020

Oh, I just went to Google for solutions for some cargo fmt magic that doesn't affect the git history as much and after reading through an interesting thread I found a familiar name... :D

greshake/i3status-rust#340

How would you feel about implementing a similar policy on this project ;)
I experience having to manually format my code and generally working with inconsistent code style as quite cumbersome.
I mean, it's not a huge deal but it's just one of those things that gets more and more annoying over time, so I'd be quite happy if a similar solution could be deployed here.

@atheriel
Copy link
Collaborator

Yep, I’m happy to do a similar thing for this project. But I will probably do it myself, in master, instead of via PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants