Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipad, edit photo button does nothing #126

Closed
plegall opened this issue May 23, 2017 · 3 comments
Closed

ipad, edit photo button does nothing #126

plegall opened this issue May 23, 2017 · 3 comments
Assignees
Labels
bug Malfunction or crash

Comments

@plegall
Copy link
Member

plegall commented May 23, 2017

When you're on a single photo, if you open the top-right menu (which should have a more appropriate icon in my opinion), the "edit" action button has no effect. The edit page does not open at all. It works fine on my iphone 6s.

piwigo-ios-ipad-bug-edit

Device : ipad 4, Piwigo Mobile 2.0.3 (20), iOS 10.3.1

@EddyLB EddyLB self-assigned this May 25, 2017
@EddyLB EddyLB added this to the Release 2.0.4 — AFNetworking migration & bug fixes milestone May 25, 2017
@EddyLB
Copy link
Collaborator

EddyLB commented May 25, 2017

Thanks. I can reproduce the issue with the simulator and a warning appears in the console.
I shall try to fix that in 2.0.4.

@EddyLB EddyLB added the bug Malfunction or crash label May 26, 2017
@EddyLB EddyLB closed this as completed May 28, 2017
@plegall
Copy link
Member Author

plegall commented May 28, 2017

I don't see the commit which fixes this bug :-/ Or maybe it was fixed with another commit and now the bug can't be reproduced?

@plegall plegall reopened this May 28, 2017
@EddyLB
Copy link
Collaborator

EddyLB commented May 28, 2017

Sorry… now done.
=> ImageDetailViewController.m

@EddyLB EddyLB closed this as completed May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Malfunction or crash
Projects
None yet
Development

No branches or pull requests

2 participants