Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient image quality due to downsampling #556

Closed
xsm1997 opened this issue Nov 13, 2023 · 0 comments
Closed

Insufficient image quality due to downsampling #556

xsm1997 opened this issue Nov 13, 2023 · 0 comments
Assignees
Labels
improvement Improves an existing feature
Milestone

Comments

@xsm1997
Copy link

xsm1997 commented Nov 13, 2023

Describe the bug and how to reproduce
The images get downsampled even full resolution is selected in preferences.

It will be fine when just looking at it. But when I zoom the image, the image quality will be bad, far behind the original image.

Steps to reproduce the behavior:

  1. Open any photo

Expected behavior
Original image should be displayed if full resolution is set.

Smartphone (please complete the following information):

  • Device: iPad Pro 11 (4th gen, M2)
  • OS: iOS 17.1
  • App version 3.0.2

Additional context

let cachedImage = ImageUtilities.downsample(imageAt: cachedImageURL, to: cellSize, scale: scale)

Maybe we shouldn't downsample the image here? There is no such issue before 3.0.0 version.

@EddyLB EddyLB self-assigned this Nov 13, 2023
@EddyLB EddyLB added the improvement Improves an existing feature label Nov 13, 2023
@EddyLB EddyLB added this to the 3.1 milestone Nov 13, 2023
@EddyLB EddyLB changed the title [Bug] Bad image quality due to downsampling Insufficient image quality due to downsampling Nov 13, 2023
@EddyLB EddyLB closed this as completed in d703070 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants