Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UsdUtils.ComputeAllDependencies does not catch missing thumbnails in USDZ files #2636

Closed
dgovil opened this issue Sep 1, 2023 · 2 comments
Closed

Comments

@dgovil
Copy link
Collaborator

dgovil commented Sep 1, 2023

Description of Issue

UsdUtils.ComputeAllDependencies appears to work differently for USDZ and USD files in that the checker seems to miss that the assetInfo dictionary is pointing to an invalid asset path when the file is a USDZ, but It works correctly when you unzip the same file

This is with USD 23.8.

The attached script will run over the two files and print when it misses the check

Steps to Reproduce

  1. Download Test.zip
  2. Run the included Python script
@dgovil
Copy link
Collaborator Author

dgovil commented Sep 1, 2023

Ah this seems to be because UsdUtils_FileAnalyzer has this bit to mention.

// If the newly opened layer is a package, it we do not need to traverse
// into it as the entire package will be included as a dependency.
if (_layer->GetFileFormat()->IsPackage()) {
        return;
}

So at least the cause is clear, though I think maybe the assumption in the code isn't accurate, because a USDZ may have external references that are unresolvable (per our previous discussions)

I'll submit a PR with that removed. I don't believe there are any side effects to the removal in my testing

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants