Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve discovery of MaterialX vector3 inputs #1790

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Improve discovery of MaterialX vector3 inputs #1790

merged 1 commit into from
Mar 8, 2022

Conversation

seando-adsk
Copy link
Contributor

Description of Change(s)

  • Removes hardcoded list in _IsInputVector3
  • Replicates existing code from _AddMaterialXNode

Fixes Issue(s)

  • I have submitted a signed Contributor License Agreement

@JGamache-autodesk @seando-adsk
Improve discovery of MaterialX vector3 inputs
b598c7e 
Fixes PixarAnimationStudios#1785

- Removes hardcoded list in _IsInputVector3
- Replicates existing code from _AddMaterialXNode
@jilliene
Copy link

Filed as internal issue #USD-7250

@pixar-oss pixar-oss merged commit 20a9fe4 into PixarAnimationStudios:dev Mar 8, 2022
@JGamache-autodesk JGamache-autodesk mentioned this pull request Mar 11, 2022
Closed
@seando-adsk seando-adsk deleted the adsk/fix_materialx_vector3_inputs branch March 18, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seando-adsk @jilliene @pixar-oss @JGamache-autodesk