Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom camera attributes aren't considered in UsdImagingCameraAdapter::TrackVariability #1797

Closed
robpieke opened this issue Mar 7, 2022 · 2 comments

Comments

@robpieke
Copy link
Contributor

robpieke commented Mar 7, 2022

Description of Issue

If you apply a custom schema to a camera (for example to attach a background image) and populate the custom attribute(s) with time-sampled data, Hydra doesn't trigger the appropriate syncing on frame changes. This is due to UsdImagingCameraAdapter::TrackVariability having a hard-coded list of attributes to consider.

In contrast, UsdImagingLightAdapter::TrackVariability iterates over all attributes.

PR for consideration inbound ... basically just copying what the lightAdapter does, at the end of the cameraAdapter :)

@jilliene
Copy link

jilliene commented Mar 7, 2022

Filed as internal issue #USD-7258

@sunyab
Copy link
Contributor

sunyab commented Jul 22, 2022

PR #1798 was merged and released with v22.08. Closing, thanks!

@sunyab sunyab closed this as completed Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants