APPLE: Rename MemoryBarrier func to InsertMemoryBarrier to avoid Windows issue #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creijon
changed the title
|
Filed as internal issue #USD-7820 |
creijon
force-pushed
the
jon/dev/memorybarrier_rename
branch
from
aeb8fd9
to
9729d74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
In
Windows.hthere is the statement:#define MemoryBarrier __faststorefence. Depending on whether this header is included and in which order it is, this results in theMemoryBarriersymbol onHgiGraphicsCmdsHgiComputeCmdsandHgiBlitCmdsbeing renamed as__faststorefenceWe had to work around this in the GPU frustum culling PR, #2053, by using an
#undef, but this is fragile since re-ordering the includes could cause a regression.Perhaps a more effective solution is to rename the function? In this case to
InsertMemoryBarrier.Fixes Issue(s)