Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding issue with non ASCII characters #13

Open
cpommier opened this issue Mar 26, 2020 · 4 comments
Open

Encoding issue with non ASCII characters #13

cpommier opened this issue Mar 26, 2020 · 4 comments

Comments

@cpommier
Copy link
Contributor

cpommier commented Mar 26, 2020

Example:
current Wheat_td.csv Trait description is missing ü in Müller toward the end:

Septoria nodorum blotch incidence in the plants caused by the agent Stagonospora nodorum (syn. Septoria glume blotch) (Phaeosphaeria nodorum (E. M ller) Hedjaroude (syn. Stagonospora nodorum).

Should be:

Septoria nodorum blotch incidence in the plants caused by the agent Stagonospora nodorum (syn. Septoria glume blotch) (Phaeosphaeria nodorum (E. Müller) Hedjaroude (syn. Stagonospora nodorum).

I have created a dedicated branch. We are working on it and will let you know as soon as it seems complete by assigning it to @marieALaporte if that's fine with you. Let us know if you want to discuss this.

@cpommier
Copy link
Contributor Author

@cooperl09
Copy link
Member

It is correct in the obo file.
Also displays correctly on our browser: http://dev.planteome.org/amigo/term/CO_321:0000917 (set text encoding to Western)
Capitalization does need to be corrected, though.

@cpommier
Copy link
Contributor Author

Hi
We have two masters here the obo and the csv. The obo is the master for planteome, and the csv for other systems. The obo might be ok but the csv is broken, hence need fixing.
There are some synonyms and some variable name that have encoding problems too, and that's an integration problem that needs solving quickly :)

@cpommier
Copy link
Contributor Author

Ok it seems better now. I propose two merge request:

  • One to rationalize trait classs, to merge or discuss first
  • One for encoding to merge in master once it has received the first one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants