Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upsample data above midplane to full grid assuming stellarator symmetry #1206

Open
unalmis opened this issue Aug 20, 2024 · 3 comments
Open
Labels
P3 Highest Priority, someone is/should be actively working on this performance New feature or request to make the code faster

Comments

@unalmis
Copy link
Collaborator

unalmis commented Aug 20, 2024

This would be useful for FFT's or integration over a subset of the volume as discussed in #1101 . Currently algorithms that rely on such computations are forced to compute on the full volume, which impacts performance (memory and speed). Once we have a utility like

def map2fullgrid(grid, data):
   """Return data computed on grid as if it were computed on full grid."""

We can just call this inside the compute functions rather than raising warnings that computations are incorrect for quantities that compute integrals over subsets of the volume in #1094 .

@unalmis unalmis added the performance New feature or request to make the code faster label Aug 20, 2024
@unalmis unalmis changed the title Utility to upsample data computed above midplane to full volume assuming stellarator symmetry Upsample data computed above midplane to full grid assuming stellarator symmetry Aug 20, 2024
@unalmis unalmis changed the title Upsample data computed above midplane to full grid assuming stellarator symmetry Upsample data above midplane to full grid assuming stellarator symmetry Aug 20, 2024
@dpanici
Copy link
Collaborator

dpanici commented Aug 20, 2024

Need to consider symmetry of the underlying data

@unalmis unalmis added the low priority Nice to have, but not needed right away label Aug 20, 2024
@dpanici
Copy link
Collaborator

dpanici commented Aug 27, 2024

Could check if at theta=0, zeta=0 the value is zero, then it is sin sym, but I would prefer to manually specify the symmetry

@unalmis unalmis removed the low priority Nice to have, but not needed right away label Nov 3, 2024
@dpanici dpanici added the P2 Medium Priority, not urgent but should be on the near-term agend label Nov 11, 2024
@dpanici
Copy link
Collaborator

dpanici commented Nov 18, 2024

# TODO: remove when boozer transform works with multiple surfaces

@unalmis unalmis added P3 Highest Priority, someone is/should be actively working on this and removed P2 Medium Priority, not urgent but should be on the near-term agend labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Highest Priority, someone is/should be actively working on this performance New feature or request to make the code faster
Projects
None yet
Development

No branches or pull requests

2 participants