Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logic error about print encoding statistics result in octree_pointcloud_compression.hpp #1745

Closed
fengjim opened this issue Oct 27, 2016 · 4 comments

Comments

@fengjim
Copy link
Contributor

fengjim commented Oct 27, 2016

⚠️ This is a issue tracker, please use our mailing list for questions: www.pcl-users.org. ⚠️

Your Environment

  • Operating System and version: any
  • Compiler: any
  • PCL Version: master branch

Expected Behavior

in octree_pointcloud_compression.hpp, around line 153# to 156#, it checks member 'i_frame_' to decide print 'Encoding Frame: Intra frame' or 'Encoding Frame: Prediction Frame'. However, 'i_frame_' will always be set as 'false' after switch buffer once encoding is done, see line 141#. Consequently statistic result always show 'Encoding Frame: Prediction Frame'.

Line 141# 'i_frame_ = false;' should be moved down after printing statistics.

Current Behavior

Possible Solution

Code to Reproduce

Context

@SergioRAgostinho
Copy link
Member

Can you please file a pull request. Thanks.

@fengjim
Copy link
Contributor Author

fengjim commented Oct 28, 2016

Thanks, SergioRAgostinho!

Pull Request is sent: #1749

@stale
Copy link

stale bot commented May 19, 2020

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the status: stale label May 19, 2020
@mvieth
Copy link
Member

mvieth commented Mar 20, 2021

I guess since the pull request is merged, this issue can be closed. Thanks!

@mvieth mvieth closed this as completed Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants