Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C++11 code instead of Boost in metslib #2954

Open
SunBlack opened this issue Mar 29, 2019 · 3 comments
Open

Use C++11 code instead of Boost in metslib #2954

SunBlack opened this issue Mar 29, 2019 · 3 comments

Comments

@SunBlack
Copy link
Contributor

Currently metslib of PCL requires boost, because of this commit 57ace9a. Even if we revert changes from there it won't compile, because metslib is using tr1 and not final C++11 standard and there is no update to this lib. So we should adjust code there.

@SergioRAgostinho
Copy link
Member

SergioRAgostinho commented Apr 3, 2019

We definitely need to adjust the code here, because the later versions of the library is GPL and ours is licenced under BSD. This is the first import into GitHub from of mets.h. It has a copyright from 2006-2008, ours has 2006-2012 and is under BSD. The commit message reads, "modified to use BSD". The author does seem to be affiliated with the project https://github.com/coin-or/metslib/graphs/contributors

Did the author waive the licence restrictions in order to be included in PCL? @taketwo @jspricke

@taketwo
Copy link
Member

taketwo commented Apr 5, 2019

Given that the commit author is the author of Metslib, I guess he had legal rights to waive license restrictions.

👍 for adjusting code.

@stale
Copy link

stale bot commented May 19, 2020

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants