Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCLPointCloud2 concatenation operation needs to consider the field size #3337

Open
kunaltyagi opened this issue Sep 7, 2019 · 1 comment
Open

PCLPointCloud2 concatenation operation needs to consider the field size #3337

kunaltyagi opened this issue Sep 7, 2019 · 1 comment
Labels
kind: todo Type of issue module: common

Comments

@kunaltyagi
Copy link
Member

Currenty, PCLPointCloud2::concatenate assumed same name implies same datatype. WIth the PR #3312 this will no longer be true. This issue was found during refactoring of #3320

Context

Fields will no longer be restricted to float_32 so concatenating it with a field of datatype float_64 will result in a corrupted output.

Expected Behavior

During concatenation, a check of field datatype should be performed
@DaniilSNikulin DaniilSNikulin mentioned this issue Oct 31, 2019
Open
@stale
Copy link

stale bot commented May 19, 2020

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the status: stale label May 19, 2020
@kunaltyagi kunaltyagi added the kind: todo Type of issue label May 20, 2020
@stale stale bot removed the status: stale label May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: todo Type of issue module: common
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taketwo @kunaltyagi