Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CI to multi-stage pipelines #3594

Open
kunaltyagi opened this issue Jan 23, 2020 · 7 comments
Open

Convert CI to multi-stage pipelines #3594

kunaltyagi opened this issue Jan 23, 2020 · 7 comments
Labels
help wanted kind: todo Type of issue module: ci skill: azure Skills/areas of expertise needed to tackle the issue status: stale

Comments

@kunaltyagi
Copy link
Member

kunaltyagi commented Jan 23, 2020

Your Environment

  • Operating System and version: All CI

Context

Currently, each CI is single stage, completely independent of each other.

Expected Behavior

Splitting CI into stages will allow:

  • Better diagnostics: pipeline A failed at stage: build or test
  • More free time:
    • sometimes jobs fail formatting, but continue consuming the CI time for build+test. This will be done again after formatting is fixed.
    • tutorials are built in parallel, leading to double compilation of base library
  • More flexibility: addition of API/ABI breakage will be easier
@kunaltyagi kunaltyagi added good first issue Skills/areas of expertise needed to tackle the issue module: ci labels Jan 23, 2020
@taketwo
Copy link
Member

taketwo commented Jan 23, 2020

I was interested in making "Tutorials" a follow-up stage for the library build, so I've looked into this some time ago. I do not recall what was the culprit, but I could not achieve this either at all, or in reasonable time. So not sure if this qualifies as "good first issue". Things might have changed since then though.

@kunaltyagi kunaltyagi added help wanted and removed good first issue Skills/areas of expertise needed to tackle the issue labels Jan 23, 2020
@shrijitsingh99
Copy link
Contributor

We can have a pipeline with stages like this?
Formatting -> Build -> Tutorials -> Documentation
We can make Tutorials & Documentation reuse already built modules using caching.
Why do we have separate jobs for tutorial and documentation, shouldn't they be combined?

@kunaltyagi
Copy link
Member Author

kunaltyagi commented Mar 24, 2020

Slight difference in build flags (PCL_NO_PRECOMPILE ON/OFF). But formatting should be a precursor to all other jobs.

But yes, Format -> Build matrix -> Test -> Tutorial is a nice sequence. I don't know where documentation would fit best

@taketwo
Copy link
Member

taketwo commented Mar 24, 2020

Why do we have separate jobs for tutorial and documentation, shouldn't they be combined?

'Tutorials' job is building the tutorials code, not the tutorials HTML pages.

@shrijitsingh99
Copy link
Contributor

Slight difference in build flags (PCL_NO_PRECOMPILE ON/OFF). But formatting should be a precursor to all other jobs.

But yes, Format -> Build matrix -> Test -> Tutorial is a nice sequence. I don't know where documentation would fit best

We can have a parallel job for Documentation.

@kunaltyagi
Copy link
Member Author

Dividing this issue request in 2 parts:

@stale
Copy link

stale bot commented May 19, 2020

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the status: stale label May 19, 2020
@kunaltyagi kunaltyagi added kind: todo Type of issue skill: azure Skills/areas of expertise needed to tackle the issue labels May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted kind: todo Type of issue module: ci skill: azure Skills/areas of expertise needed to tackle the issue status: stale
Projects
None yet
Development

No branches or pull requests

3 participants