Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coding mistake in io/src/ply_io.cpp #3599

Closed
DiscreteLogarithm opened this issue Jan 24, 2020 · 2 comments · Fixed by #3601
Closed

coding mistake in io/src/ply_io.cpp #3599

DiscreteLogarithm opened this issue Jan 24, 2020 · 2 comments · Fixed by #3601

Comments

@DiscreteLogarithm
Copy link
Contributor

In line 1772 fs.close() should have been fpout.close(). fs has been closed before (on line 1685). This is actually not a bug as the fstream destructor always closes the file and line 1772 is redundant anyway.

I think it should be changed to correct code or removed altogether.
@kunaltyagi
Copy link
Member

Thanks for reporting the bug @DiscreteLogarithm

Would you mind creating a PR for this? 😄

@DiscreteLogarithm DiscreteLogarithm mentioned this issue Jan 25, 2020
Merged
@DiscreteLogarithm
Copy link
Contributor Author

@kunaltyagi done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close the correct file in pcl::io::savePLYFileBinary DiscreteLogarithm/pcl
2 participants
@DiscreteLogarithm @kunaltyagi