Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.11.0 Release #3661

Closed
1 of 2 tasks
kunaltyagi opened this issue Feb 21, 2020 · 14 comments · Fixed by #4075
Closed
1 of 2 tasks

1.11.0 Release #3661

kunaltyagi opened this issue Feb 21, 2020 · 14 comments · Fixed by #4075
Labels
needs: pr merge Specify why not closed/merged yet
Milestone

Comments

@kunaltyagi
Copy link
Member

kunaltyagi commented Feb 21, 2020

Context

Next version release with backlog items + new features.

Backlog from #2772 (1.10.0 Release)

Backlog moved to 1.12.0 Release pending discussion regarding the status of random in PCL (#3996)

PS: It might be more prudent to do a faster release since 1.9.1 was on 2018 Nov 26 and 1.10 was on 2020 Jan 20. Scheduled releases might be better (aka every N months, come hell or high water) to prevent huge changes and giving something new every release. Some will be small, some will be large; doesn't matter.

@kunaltyagi kunaltyagi added this to the pcl-1.11.0 milestone Feb 21, 2020
@taketwo
Copy link
Member

taketwo commented Feb 22, 2020

I recall discussing scheduled (aka "regular") releases quite a few times. Let's see how far we get this time :)

I'd like to have 1.10.1 soon because we had some header issues in 1.10.0.

@kunaltyagi
Copy link
Member Author

What's blocking 1.10.1? Doing it before GSoC kicks would be best. There's already a lot of commits since 1.10, some might be breaking API/ABI (don't remember which one. It would be one of mine though)

@taketwo
Copy link
Member

taketwo commented Feb 24, 2020

some might be breaking API/ABI

At least none are labeled as such: https://github.com/PointCloudLibrary/pcl/pulls?page=2&q=is%3Apr+merged%3A%3E2020-01-19&utf8=%E2%9C%93

What's blocking 1.10.1?

I want to try to build a large codebase that uses plenty of PCL. Some ROS packages and proprietary projects at my company. So far no time :(

@tompollok
Copy link

Is it planned to completely deboostify pcl with 1.11 release?

@kunaltyagi
Copy link
Member Author

kunaltyagi commented Apr 2, 2020

We're on track to do that, but I don't know when we plan to flip the switch.

EDIT: De-boostify in terms of features that are provided by C++14 only. Boost is and remains an important ecosystem on which PCL depends

@kunaltyagi
Copy link
Member Author

@taketwo you mentioned you compile PCL for some open (and closed) source projects. Which ones are those? That'll help in creating a release pipeline

@taketwo
Copy link
Member

taketwo commented Apr 28, 2020

At my company, we use a lot of PCL+ROS. We package PCL ourselves, as well as those ROS packages that depend on it.

@kunaltyagi
Copy link
Member Author

IIRC, PCL is an indirect dependency of other ROS packages, via the package perception_pcl. Just compiling perception_pcl would be sufficient for starters, right?

@taketwo
Copy link
Member

taketwo commented Apr 28, 2020

Here is what I get with $ apt-cache rdepends --installed libpcl-dev | uniq on my system (proprietary packages stripped):

  ros-melodic-cartographer-ros
  ros-melodic-pcl-ros
  ros-melodic-pcl-conversions

So yes, I think perception_pcl would be sufficient for starters.

@kunaltyagi
Copy link
Member Author

Note to self: kinetic and melodic are the active distributions

@kunaltyagi
Copy link
Member Author

Where can I find the cmake flags used in configuration for debian release?

@jspricke
Copy link
Member

https://sources.debian.org/src/pcl/1.10.1+dfsg-1/debian/rules/
and dpkg-buildflags

@SergioRAgostinho
Copy link
Member

SergioRAgostinho commented Apr 29, 2020

Debian is building its packages with clang 😮

@jspricke
Copy link
Member

https://salsa.debian.org/science-team/pcl/-/commit/0cf19f69887891f6fcdf43863e49dcc608cc62c4

@kunaltyagi kunaltyagi added the needs: pr merge Specify why not closed/merged yet label May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: pr merge Specify why not closed/merged yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants