Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PointXYZLAB to common? #4600

Closed
mvieth opened this issue Feb 9, 2021 · 1 comment · Fixed by #4706
Closed

Move PointXYZLAB to common? #4600

mvieth opened this issue Feb 9, 2021 · 1 comment · Fixed by #4706
Labels
effort: low Rough estimate of time needed to fix/implement/solve kind: proposal Type of issue

Comments

@mvieth
Copy link
Member

mvieth commented Feb 9, 2021

The point type PointXYZLAB is currently defined in gicp6d. The definition could be moved to point_types.h and point_types.hpp, and conversions could be moved from gicp6d.cpp to point_types_conversion.h

Pros:

  • Types like PointXYZRGB(A) and PointXYZHSV are in point_types
  • Currently doxygen seems to be confused by the macros in gicpd6d.h (see here under Function Documentation), that would be solved by moving the definitions

Cons:

  • Currently PointXYZLAB is only used by GeneralizedIterativeClosestPoint6D
@mvieth mvieth added kind: proposal Type of issue status: triage Labels incomplete labels Feb 9, 2021
@kunaltyagi
Copy link
Member

Not against the proposal, and the cons is not that big of an issue (IETF style)

@mvieth mvieth added effort: low Rough estimate of time needed to fix/implement/solve and removed status: triage Labels incomplete labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Rough estimate of time needed to fix/implement/solve kind: proposal Type of issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants