Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] Bot is travelling ridiculously slow, further away and missing pokestops #2131

Closed
AlexBailey opened this issue Jul 31, 2016 · 33 comments
Closed

Comments

@AlexBailey
Copy link

AlexBailey commented Jul 31, 2016

The Dev bot is walking ridiculously slow in some cases (possibly left to right, but at the same speed, as this is measured by distance to the set pokestop?) and sometimes even just walks past the pokestop completely and heads to another instead? I'm on the latest release.

[20:17:00] Moving towards fort West India Quay DLR Station, 0.06km left
[20:17:05] Moving towards fort West India Quay DLR Station, 0.06km left
[20:17:18] Moving towards fort West India Quay DLR Station, 0.06km left
[20:17:21] Moving towards fort West India Quay DLR Station, 0.06km left
[20:17:33] Moving towards fort West India Quay DLR Station, 0.06km left
[20:17:51] Moving towards fort West India Quay DLR Station, 0.07km left
[20:17:54] Moving towards fort West India Quay DLR Station, 0.06km left
[20:18:02] Moving towards fort West India Quay DLR Station, 0.06km left
[20:18:14] Moving towards fort West India Quay DLR Station, 0.07km left
[20:18:23] Moving towards fort West India Quay DLR Station, 0.07km left
[20:18:35] Moving towards fort West India Quay DLR Station, 0.08km left
[20:18:42] Moving towards fort West India Quay DLR Station, 0.08km left
[20:18:44] [x] Next egg incubates in 4.36 km
[20:18:55] Moving towards fort West India Quay DLR Station, 0.08km left
[20:19:07] Moving towards fort West India Quay DLR Station, 0.09km left
[20:19:19] Moving towards fort West India Quay DLR Station, 0.10km left
[20:19:27] Moving towards fort West India Quay DLR Station, 0.10km left
[20:19:35] Moving towards fort West India Quay DLR Station, 0.09km left
[20:19:48] Moving towards fort West India Quay DLR Station, 0.10km left
[20:19:55] Moving towards fort West India Quay DLR Station, 0.10km left
[20:20:03] Moving towards fort West India Quay DLR Station, 0.10km left
[20:20:20] Moving towards fort West India Quay DLR Station, 0.10km left
[20:20:32] Moving towards fort West India Quay DLR Station, 0.10km left
[20:20:45] Moving towards fort West India Quay DLR Station, 0.11km left
[20:20:57] Moving towards fort West India Quay DLR Station, 0.11km left
[20:21:09] Moving towards fort West India Quay DLR Station, 0.11km left
[20:21:22] Moving towards fort Strange Purple Sculpture, 0.12km left
[20:21:30] Moving towards fort Strange Purple Sculpture, 0.11km left
[20:21:38] Moving towards fort Strange Purple Sculpture, 0.09km left
[20:21:41] Walking from (51.508181797941496, -0.02132928682461375) to [51.508173448174894, -0.019475690805081554] 0.13km
[20:21:46] Moving towards fort Strange Purple Sculpture, 0.09km left
[20:21:54] Moving towards fort Strange Purple Sculpture, 0.09km left
[20:22:07] Moving towards fort Strange Purple Sculpture, 0.09km left
[20:22:15] Moving towards fort Strange Purple Sculpture, 0.09km left
[20:22:31] Moving towards fort Strange Purple Sculpture, 0.10km left
[20:22:41] Moving towards fort Strange Purple Sculpture, 0.10km left
[20:22:43] [x] Next egg incubates in 4.27 km
[20:22:44] Moving towards fort Strange Purple Sculpture, 0.10km left
[20:22:56] Moving towards fort Strange Purple Sculpture, 0.10km left
[20:23:04] Moving towards fort Strange Purple Sculpture, 0.10km left
[20:23:21] Moving towards fort Strange Purple Sculpture, 0.11km left
[20:23:33] Moving towards fort Strange Purple Sculpture, 0.11km left
[20:23:41] Moving towards fort Strange Purple Sculpture, 0.11km left
[20:23:49] Moving towards fort Strange Purple Sculpture, 0.11km left
[20:23:57] Moving towards fort Strange Purple Sculpture, 0.11km left
[20:24:10] Moving towards fort Strange Purple Sculpture, 0.11km left
[20:24:17] Moving towards fort Strange Purple Sculpture, 0.11km left
[20:24:25] Moving towards fort Strange Purple Sculpture, 0.11km left
[20:24:37] Moving towards fort Strange Purple Sculpture, 0.12km left
[20:24:50] Moving towards fort Strange Purple Sculpture, 0.12km left
[20:25:02] Moving towards fort Strange Purple Sculpture, 0.12km left
[20:25:10] Moving towards fort Strange Purple Sculpture, 0.12km left
[20:25:23] Moving towards fort Former White Horse Pub Sign, 0.13km left
[20:25:31] Moving towards fort Former White Horse Pub Sign, 0.12km left
[20:25:48] Moving towards fort Former White Horse Pub Sign, 0.13km left
[20:26:00] Moving towards fort Former White Horse Pub Sign, 0.13km left
[20:26:08] Moving towards fort Former White Horse Pub Sign, 0.13km left
[20:26:25] Moving towards fort Will Crooks Estate, 0.13km left
[20:26:42] Moving towards fort Will Crooks Estate, 0.13km left
[20:26:44] [x] Next egg incubates in 4.20 km
[20:26:50] Moving towards fort Will Crooks Estate, 0.12km left
[20:26:58] Moving towards fort Will Crooks Estate, 0.11km left
[20:27:14] Moving towards fort Will Crooks Estate, 0.11km left
[20:27:26] Moving towards fort Will Crooks Estate, 0.11km left
[20:27:39] Moving towards fort Will Crooks Estate, 0.12km left
[20:27:52] Moving towards fort Will Crooks Estate, 0.12km left
[20:28:00] Moving towards fort Poplar Station, 0.12km left
[20:28:03] Walking from (51.50815980303424, -0.0194107861105448) to [51.50637344817489, -0.019475690805081554] 0.20km
[20:28:08] Moving towards fort Poplar Station, 0.12km left
[20:28:20] Moving towards fort Poplar Station, 0.11km left
[20:28:33] Moving towards fort Poplar Station, 0.11km left
[20:28:41] Moving towards fort Poplar Station, 0.10km left
[20:28:53] Moving towards fort Poplar Station, 0.10km left
[20:29:08] Moving towards fort Poplar Station, 0.10km left
[20:29:20] Moving towards fort Poplar Station, 0.09km left
[20:29:28] Moving towards fort Poplar Station, 0.09km left
[20:29:45] Moving towards fort West India Quay DLR Station, 0.10km left
[20:29:57] Moving towards fort West India Quay DLR Station, 0.08km left
[20:30:09] Moving towards fort West India Quay DLR Station, 0.07km left
[20:30:17] Moving towards fort West India Quay DLR Station, 0.07km left
[20:30:31] Moving towards fort West India Quay DLR Station, 0.06km left
[20:30:34] Moving towards fort West India Quay DLR Station, 0.05km left
[20:30:46] Moving towards fort West India Quay DLR Station, 0.05km left
[20:30:48] [x] Next egg incubates in 4.05 km
[20:30:59] Moving towards fort West India Quay DLR Station, 0.04km left
[20:31:07] Now at Pokestop: West India Quay DLR Station
[20:31:07] Spinning ...
[20:31:07] Loot:
[20:31:07] 50 xp
[20:31:08] - 3x Pokeball (Total: 53)
[20:31:08] PokeStop on cooldown. Time left: 4 minutes, 59 seconds

@klingan
Copy link
Contributor

klingan commented Jul 31, 2016

Please try switching MoveToFort and SpinFort tasks, I think I found the problem but need validation

@AlexBailey
Copy link
Author

@klingan By switching, do you literally mean to replace MoveToFort with SpinFort and SpinFort to where MoveToFort was?

@klingan
Copy link
Contributor

klingan commented Jul 31, 2016

yes, so it executes MoveToFort first and then tries to SpinFort

@captainmustard
Copy link

I have the same problem, but it seems that mine is just following a spiral and not pathing towards pokestops at all.

@AlexBailey
Copy link
Author

@klingan Ok, I've done that and saved the config and ran it again - it did not solve the problem, here's what I've got:

[20:47:06] Moving towards fort Canary Wharf Clocks, 0.05km left
[20:47:14] Moving towards fort Canary Wharf Clocks, 0.05km left
[20:47:22] Moving towards fort Canary Wharf Clocks, 0.05km left
[20:47:35] Moving towards fort Canary Wharf Clocks, 0.06km left
[20:47:42] Moving towards fort Canary Wharf Clocks, 0.06km left
[20:47:50] Moving towards fort Canary Wharf Clocks, 0.06km left
[20:47:58] Moving towards fort Canary Wharf Clocks, 0.06km left
[20:48:11] Moving towards fort Canary Wharf Clocks, 0.06km left
[20:48:19] Moving towards fort Canary Wharf Clocks, 0.07km left

Nothing seems to have changed at all

@jayhostan
Copy link

jayhostan commented Jul 31, 2016

having the same issue. also, when removing followspiral task its not moving at all

@captainmustard
Copy link

same here, removing followspiral causes nothing to move. swapping movetofort and spinfort changed nothing

@klingan
Copy link
Contributor

klingan commented Jul 31, 2016

Hmm, ok, back to the drawing board :(
Must have been coincidal then.

@WillM88
Copy link

WillM88 commented Jul 31, 2016

Is it basically having a hard time determining which location is closer when the distances are similar so it keeps dancing between the two or three?

@MatthewBCooke
Copy link

The issue seems to be that it will always go to the closer location, but sometimes these change because of the human walking.
I'm going to try to make the decision of walking toward fort x final. No changing it's mind until it reaches it.
That should fix it.

@jayhostan
Copy link

whats happened just now:

[21:00:50] Moving towards fort Royal Arcade, 0.05km left
[21:00:53] Walking from (51.50860284129672, -0.14139971011091698) to [51.50675269791626, -0.14138983275818395] 0.21km
[21:00:58] Moving towards fort Royal Arcade, 0.05km left
[21:01:10] Moving towards fort Royal Arcade, 0.05km left
[21:01:18] Moving towards fort Royal Arcade, 0.06km left
[21:01:31] Moving towards fort Royal Arcade, 0.06km left
[21:01:39] Moving towards fort Royal Arcade, 0.06km left

so the little guy is right next to that fort. this went on for 3 mins! changing btween 0.05 - 0.06

then: an other event kicked in , this case egg hatched. right after that:

[21:03:54] [x] Now incubating a 5.0km egg
[21:04:01] Moving towards fort Royal Arcade, 0.05km left
[21:04:05] Moving towards fort Royal Arcade, 0.04km left
[21:04:13] Arrived at pokestop.
[21:04:13] Now at Pokestop: Royal Arcade

so seems like an event can break the confusion

@klingan
Copy link
Contributor

klingan commented Jul 31, 2016

Just noticed that sometimes suddenly nearest_fort is None
Further debugging

@sgitkene
Copy link

#2124 see this issue.
maybe bag is full?
turn off FollowSpiral in config, make sure you have a non full bag.

@klingan
Copy link
Contributor

klingan commented Jul 31, 2016

[16:28:15] MoveToForWorker executed
[16:28:15] I have space for loot? True
[16:28:15] I am softbanned? False
[16:28:15] Nearest fort: 648b964360ff428c9df11475f42bd2e2.12
[16:28:15] MoveToFortWorker: dist = 48.8493286389
[16:28:15] Moving towards fort Hendrik en Katrien(648b964360ff428c9df11475f42bd2e2.12), 48.85m left
[16:28:19] Returning RUNNING
[16:28:19] Worker <pokemongo_bot.cell_workers.move_to_fort.MoveToFort object at 0x392b0d0> returned RUNNING
[16:28:20] Counting items: {1: 92, 2: 25, 3: 45, 101: 10, 102: 20, 103: 30, 201: 30, 401: 7, 501: 5, 701: 16, 901: 1}
[16:28:20] Something rustles nearby!
[16:28:26] MoveToForWorker executed
[16:28:26] I have space for loot? True
[16:28:26] I am softbanned? False
[16:28:26] Nearest fort: 648b964360ff428c9df11475f42bd2e2.12
[16:28:26] MoveToFortWorker: dist = 45.8234891096
[16:28:26] Moving towards fort Hendrik en Katrien(648b964360ff428c9df11475f42bd2e2.12), 45.82m left
[16:28:29] Returning RUNNING
[16:28:29] Worker <pokemongo_bot.cell_workers.move_to_fort.MoveToFort object at 0x392b0d0> returned RUNNING
[16:28:30] [x] Next egg incubates in 0.20 km
[16:28:31] Counting items: {1: 92, 2: 25, 3: 45, 101: 10, 102: 20, 103: 30, 201: 30, 401: 7, 501: 5, 701: 16, 901: 1}
[16:28:31] Something rustles nearby!
[16:28:37] MoveToForWorker executed
[16:28:37] I have space for loot? True
[16:28:37] I am softbanned? False
[16:28:37] Nearest fort: 648b964360ff428c9df11475f42bd2e2.12
[16:28:37] MoveToFortWorker: dist = 41.2109048929
[16:28:37] Moving towards fort Hendrik en Katrien(648b964360ff428c9df11475f42bd2e2.12), 41.21m left
[16:28:40] Returning RUNNING
[16:28:40] Worker <pokemongo_bot.cell_workers.move_to_fort.MoveToFort object at 0x392b0d0> returned RUNNING
[16:28:42] Counting items: {1: 92, 2: 25, 3: 45, 101: 10, 102: 20, 103: 30, 201: 30, 401: 7, 501: 5, 701: 16, 901: 1}
[16:28:42] MoveToForWorker executed
[16:28:42] I have space for loot? True
[16:28:42] I am softbanned? False
[16:28:42] Now at 50.9297995389,5.33767871589. 35.5763846127 to go
[16:28:47] Counting items: {1: 92, 2: 25, 3: 45, 101: 10, 102: 20, 103: 30, 201: 30, 401: 7, 501: 5, 701: 16, 901: 1}
[16:28:47] Something rustles nearby!
[16:28:53] MoveToForWorker executed
[16:28:53] I have space for loot? True
[16:28:53] I am softbanned? False
[16:28:53] Nearest fort: 648b964360ff428c9df11475f42bd2e2.12
[16:28:53] MoveToFortWorker: dist = 45.205034017
[16:28:53] Moving towards fort Hendrik en Katrien(648b964360ff428c9df11475f42bd2e2.12), 45.21m left
[16:29:00] Returning RUNNING
[16:29:00] Worker <pokemongo_bot.cell_workers.move_to_fort.MoveToFort object at 0x392b0d0> returned RUNNING

@klingan
Copy link
Contributor

klingan commented Jul 31, 2016

[16:28:42] Now at 50.9297995389,5.33767871589. 35.5763846127 to go line indicates the spiral worker was executed.

@AlexBailey
Copy link
Author

@sgitkene Yeah, my bag isn't full... I can't see how this is linked as a possible solution either?

[21:27:48] Pokemon Bag: 122/250
[21:27:48] Items: 79/350

@klingan
Copy link
Contributor

klingan commented Jul 31, 2016

@AlexBailey if bag is full, MoveToFort isnt executed.

@AlexBailey
Copy link
Author

@klingan Gotcha! My apologies @sgitkene - The hunt for our solution continues...

@jayhostan
Copy link

then something should be implemented to clean up bag at this point?

@klingan
Copy link
Contributor

klingan commented Jul 31, 2016

well, it will move through the tasks again and run the Recycle worker which cleans up your bag
However, if your item limits are too high it will still be full, but thats another issue and doesnt belong here :)

@JSchwerberg
Copy link
Contributor

Commenting to re-emphasize the "moving slow part." I have walk = 5, so I should be walking 5 km/hr. Judging by incubation time, I'm walking far less than 1 km/hr!

[16:09:53] [x] Next egg incubates in 0.17 km
[16:14:17] [x] Next egg incubates in 0.15 km
[16:15:05] Moving towards fort Ballard Rock, 0.05km left
[16:18:36] [x] Next egg incubates in 0.12 km
[16:22:56] Moving towards fort Ballard Rock, 0.06km left
[16:23:00] [x] Next egg incubates in 0.10 km
[16:27:25] [x] Next egg incubates in 0.08 km
[16:32:06] [x] Next egg incubates in 0.06 km

@AlexBailey
Copy link
Author

@JSchwerberg Yeah, I should've done the math on my post too - this works out... This is also a recent ongoing problem if you do some searches for it. One that seems quite similar can be found here #1586 although he claims it to have been fixed in the recent lucky_egg merge? So perhaps this has derived from that in someway

@JSchwerberg
Copy link
Contributor

@AlexBailey Looks like your slowness isn't quite as bad as mine, by the logs. I think that this might be unrelated, though; I've opened #2141 for my slowness issue.

@captainmustard
Copy link

captainmustard commented Jul 31, 2016

screenshot from 2016-07-31 15 46 09

screenshot from 2016-07-31 16 12 35

@crusardri
Copy link

i think this will solve some of move problems.
#2054
This bot can't walk and catch pokemons at the same time

@zvvzzvvz
Copy link

zvvzzvvz commented Jul 31, 2016

I have also noticed very slow speeds.

I have only just looked the code but does all bot movement take place in step_walker.py? Surely it needs some kind of delta time implementation so that it can work out the distance that it needs to move the bot accurately?

Does the bot keep track of what time its position was last set? step_walker.py could use that to work out delta time and then use that to figure out how far it is actually supposed to move for the speed that has been set, Obviously the time would need to be set even when the bot is supposed to be standing still so it doesn't jump away from pokestops and pokemon after it has caught them.

@AlexBailey
Copy link
Author

@crusardri well no, I'd argue that, as not everyone is complaining of this - although that'd surely improve the bots overall speed as a whole, it's just make this inefficient mess faster, still inefficient and in contrast to the others, slower.

@AlexBailey
Copy link
Author

AlexBailey commented Jul 31, 2016

@MrCarlosJr https://github.com/PokemonGoF/PokemonGo-Bot/wiki/Google-Maps-API-(web-page)

edit: it seems you open loads of issues with questions that can be answered from the wiki and documentation... Try and read these to resolve your questions/issues before posting.

@vosk
Copy link

vosk commented Jul 31, 2016

Hello evereyone, just switched from the ugly master to the fugly dev-fix... I noticed
PokemonGoBot.heartbeat() in init py is also doing a update_web_location() call now. It seems to me a bit un necessary, and is using SO MANY resources that it ends up taking more time than the Step_walker sleep(1).... In other words, the bot is trying to walk at config.walk speed but its sleep()ing usually up to 4-5 seconds on my pc... Also doing a trillion request calls is a sure way to gen banned eventually.

@vosk
Copy link

vosk commented Jul 31, 2016

Also, my other two cents: TransferPokemon and RecycleItems is ALSO taking up time (and I ASSUME doing api calls).

@WillM88
Copy link

WillM88 commented Aug 1, 2016

Anybody figure out any ways to temporarily fix the issue?

@loklam
Copy link

loklam commented Aug 1, 2016

I got same issue and fixed (workaround) it. The change is pending test:
#2018

@AlexBailey
Copy link
Author

@loklam would this fix the slow walking speed (slower than config), the spiral issue @captainmustard is displaying and the walking towards, yet sometimes further away, of forts? Obviously I can see this fixes missing them from your pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests