Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Why is the log output no longer pretty? #3147

Closed
Dekryptid opened this issue Aug 8, 2016 · 6 comments
Closed

[QUESTION] Why is the log output no longer pretty? #3147

Dekryptid opened this issue Aug 8, 2016 · 6 comments

Comments

@Dekryptid
Copy link

I have been wondering, along the way, the bot log output went from being pretty with colors and proper formatting to this:

screen shot 2016-08-08 at 4 41 30 pm

Why?

I have all the debug/test flags set to false.

@leadboots5
Copy link
Contributor

They changed how logging was done

@Dekryptid
Copy link
Author

What was wrong with how it was done before?

@fyooree
Copy link

fyooree commented Aug 8, 2016

They use a own event system now.

I pushed a temporary fix which colored it again but they declined it because there is already a open pull request for this issue.

Nobody knows when this is ready though. Thats why I made the temporary fix ;)

@Vvkmnn
Copy link

Vvkmnn commented Aug 8, 2016

Nothing really, and other people have also been discussing it.

PR #2604 proposes a possible fix, and there's some temporary workarounds in #2547 and #2675.

I also thought it was fine, but @Kujawadl's post outlined some of the possible benefits.

@Dekryptid
Copy link
Author

@fyooree Hopefully not just the coloring, but also the formatting as well. It's so hard on the eyes, unlike before I could just glance it over and see what was picked up from a PokeStop and what hatched from my egg (which doesn't show at all anymore). Thanks for the links @Vvkmnn

@fyooree
Copy link

fyooree commented Aug 8, 2016

Didn't touch that but it doesn't matter anyway. We have to wait for the PR #2604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants