Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Discard to make room, not by default #3485

Closed
ghost opened this issue Aug 10, 2016 · 2 comments
Closed

[Feature Request] Discard to make room, not by default #3485

ghost opened this issue Aug 10, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 10, 2016

Currently the script discards all items above an inventory maximum, regardless of available inventory slots, and does so precisely.

Technically accurate, but not what a human player would do. Instead, the script should test to see if there are inventory slots available, then discard items to make room for potential items.

Actual Behavior

Spun pokestop The Lifeboat Station. Experience awarded: 50. Items awarded: {u'Pokeball': 1, u'Greatball': 1, u'Revive': 1}
Discarded 1x Pokeball (maximum 10).
Discarded 1x Revive (maximum 20).

@ghost
Copy link
Author

ghost commented Aug 10, 2016

I like this idea. Change title to "[Feature Request] Discard to make room, not by default"

@ghost ghost changed the title Discard to make room, not by default [Feature Request] Discard to make room, not by default Aug 10, 2016
@knobunc
Copy link

knobunc commented Aug 10, 2016

Already in dev:

      {
        "type": "RecycleItems",
        "config": {
          "min_empty_space": 15,
          "item_filter": {

min_empty_space sets the threshold for recycling. Don't set it to 5 or below or you won't spin stops.

@k4n30 k4n30 closed this as completed Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants