Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nidoran F or M #3718

Closed
LuckyMe4Evers opened this issue Aug 12, 2016 · 8 comments
Closed

Nidoran F or M #3718

LuckyMe4Evers opened this issue Aug 12, 2016 · 8 comments

Comments

@LuckyMe4Evers
Copy link
Contributor

Is there a possibility to truncate the space from Nidoran F and Nidoran M?
Because i use "nickname_template":"{name:.8s}-{iv_pct}" and they are both named Nidoran -000. If the space could be trucated then it would become NidoranF-000 or NidoranM-000.
I'm not a programmer and thats why i'm asking it.

@lambda-fairy
Copy link

Can't we just use ♀ and ♂ directly? According to this Reddit post the game supports Unicode in nicknames.

@k4n30
Copy link
Contributor

k4n30 commented Aug 23, 2016

@jrjhealey is this possible now?

@jrjhealey
Copy link

I'm not sure. I don't recall seeing any PRs to fix this (though I also didn't really look that hard).

I never bother to define rename rules, so I don't know if it's possible but perhaps you just need to define a slightly different renaming rule/different syntax to cope with the space in the name? Not sure if this is required to be integrated directly in to the bot code.

@TheSavior do you happen to know if this can be done already?

@Gobberwart
Copy link
Contributor

Adding a string replace in nickname_pokemon.py should do it, around line 334.

Eg.

    pokemon.name.replace(" ","")

@k4n30
Copy link
Contributor

k4n30 commented Aug 24, 2016

@Gobberwart PR?

@Gobberwart
Copy link
Contributor

I would but my current fork has a bunch of changes in it related to another PR, and I have no clue how to work on two simultaneous forks. Sorry, new to github.

@k4n30
Copy link
Contributor

k4n30 commented Aug 24, 2016

Branches :p

Not urgent, feel free to wait until you have finished on the current work

@Gobberwart
Copy link
Contributor

This was done and can be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants