Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling/enabling other tasks at runtime #3858

Closed
net8q opened this issue Aug 13, 2016 · 5 comments
Closed

Disabling/enabling other tasks at runtime #3858

net8q opened this issue Aug 13, 2016 · 5 comments

Comments

@net8q
Copy link
Contributor

net8q commented Aug 13, 2016

I'm developping a somewhat sizable plugin (thanks to the new plugin config) mainly for fun and learning python.

Problem :

I'd like to use a navigator in one of my tasks, and fallback on a known one (Spiral or whatever) if conditions are not met, but I think it's quite ugly, and users should be able to use the config file to setup their own fallback navigator.

Feature :

  • Add for each task an optional "name" field from config, with default value the task class name
  • Add a function to get the task instance with given name from the bot
  • Add a function to enable/disable running this task during runtime (as opposed to editing config to set enabled to true or false and relaunching bot)

"Manager" tasks could then be written to switch the tasks around based on conditions :

  • Having several FollowPath tasks being switched according to time (at day around your workplace, at night around your home)
  • Having FollowSpiral take cleanly over MoveToFort when bag is full
    etc.

Other Information

OS: Linux
Branch: dev
Git Commit: git merge-base HEAD origin/dev : d4200e9
Python Version: Python 2.7.10

@net8q net8q closed this as completed Aug 14, 2016
@k4n30 k4n30 reopened this Aug 14, 2016
@k4n30 k4n30 changed the title [Feature] API for disabling/enabling other tasks at runtime Disabling/enabling other tasks at runtime Aug 18, 2016
@k4n30
Copy link
Contributor

k4n30 commented Aug 24, 2016

@mjmadsen y the close?

@mjmadsen
Copy link
Contributor

There should be an enable/disable option on all options now. #4603

@k4n30
Copy link
Contributor

k4n30 commented Aug 24, 2016

Agree, but don't think that meets the entirety of the FR

@mjmadsen
Copy link
Contributor

Alright. Reopening. My bad.

@mjmadsen mjmadsen reopened this Aug 24, 2016
@mjmadsen
Copy link
Contributor

@net8q Can we get a todo list of what has or has not been done in this? Between the title and the description, there is a wide variance. I keep looking at in the issues list thinking "oh, we did that".

@k4n30 k4n30 closed this as completed Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants