Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log not showing softban fix #3919

Closed
icecubeice opened this issue Aug 14, 2016 · 6 comments
Closed

Log not showing softban fix #3919

icecubeice opened this issue Aug 14, 2016 · 6 comments

Comments

@icecubeice
Copy link

icecubeice commented Aug 14, 2016

Expected Behavior

log shows if softban is fixed

Actual Behavior

[Edit] when fixing softban it shows nothing, after it says probably got softban it then goes to the same pokestop then voila! softban is gone

Other Information

OS: Windows 10
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)
Python Version: (run 'python -V' and paste it here)

@Faithu
Copy link

Faithu commented Aug 14, 2016

You need to get to a pokestop for it to unban.

@icecubeice
Copy link
Author

@Faithu I looked through some commits and now it fixes but no log that says softban is fixed, but the proof is that I can spin already compared to before

@fari-99
Copy link

fari-99 commented Aug 14, 2016

hmm, please change the title to "log after softban fix not appear" or close this issue, because the softban is fixed.

@k4n30 k4n30 changed the title Softban not fixing Log not showing softban fix Aug 14, 2016
@k4n30
Copy link
Contributor

k4n30 commented Aug 14, 2016

@icecubeice I'm assuming you don't have any logs to indicate the issue you were experiencing?

@icecubeice
Copy link
Author

@k4n30 rn nothing, I'm describing it though, I mean after changing the softban python file through some commit it was fixed but it just doesn't show that it's fixed

@k4n30
Copy link
Contributor

k4n30 commented Aug 14, 2016

@icecubeice - I had a look and handle_soft_ban.py hasn't changed for 3 days and even then it wasn't a big change, so there haven't been major changes for nearly 2 weeks. As I don't know what commit you were on before and what commit you're on now, it's hard to call this a bug, especially without any logs.

The other thing to take into account is the newer soft ban methods which aren't fully understood when the recent ban waves hit. Your soft ban could have been one of these which happened to have resolved itself around the time the problem went away

The soft ban file "looks" to be correct so I'm going to close this issue as there are too many unknowns. Feel free to come back and reopen it if you come across the issue again.

@k4n30 k4n30 closed this as completed Aug 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants