Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflict with keep_best_iv and release_below_iv #4094

Closed
Tagada22 opened this issue Aug 16, 2016 · 20 comments
Closed

conflict with keep_best_iv and release_below_iv #4094

Tagada22 opened this issue Aug 16, 2016 · 20 comments

Comments

@Tagada22
Copy link

hello,

i have a problems with my config

i want use this 2 variable

  "any": {"release_below_cp": 0, "release_below_iv": 0.9, "logic": "or"},
  "any": {"keep_best_iv": 2}

but not working together .

i tried that

  "any": {"release_below_cp": 0, "release_below_iv": 0.9, "logic": "or"},
  "any": {"keep_best_iv": 2}

just " keep_best_iv : 2 working but not release_below_iv in bot

i tried that too

  "any": {"release_below_cp": 0, "keep_best_iv": 1, "release_below_iv": 0.8, "logic": "or"},

Problems just release_below_iv: 0.9 working and not keep_best_iv .

Do you know this problems and have you got an idea ?

thanks

@Setsu-BHMT
Copy link

You can't define "any" or any specific pokemon twice like you did in the first 2 examples. The third example should work, and it will:

  1. Keep the best IV
  2. From the remaining pokemon release anything that has iv less than 0.8

@Tagada22
Copy link
Author

Thanks

Si i do add manually all Pokemon ?

Have you got exemple ?

( sorry for my bad english )

@Tagada22 Tagada22 reopened this Aug 16, 2016
@Setsu-BHMT
Copy link

The rule "any" applies to all pokemon.
You will need to define specific pokemon only if you want to override the generic rule.
For example:

"any": { "keep_best_iv": 2 }
"Ratatta": { "release_below_cp": 0, "release_below_iv": 0.8, "logic": "or" }

Will keep any Ratatta that has IV equal to or above 0.8, and only keep the best 2 IV pokemon for any other pokemon.

@Tagada22
Copy link
Author

Ok thanks for tour help

@dblinski
Copy link

For logic, use and instead of or.
e.g.
"any": { "keep_best_iv": 2, "release_below_cp": 1000, "release_below_iv": 0.8, "logic": "and"},

@Setsu-BHMT
Copy link

@dblinski his "release_below_cp" is set to 0, meaning he does not want to release by any CP criteria, thus "or" is fine. In fact, in his case "and" will never work, since no pokemon can have CP < 0

@Tagada22 Tagada22 reopened this Aug 16, 2016
@Tagada22
Copy link
Author

I try that

"Any": {"keep_best_iv": 2, "release_below_cp": 600, "release_below_iv": 0.9, "Logic": "and"}

But not working ,not transfert !!

cubates in 0.37 km
2016-08-16 21:13:00,054 [EvolvePokemon] [INFO] [skip_evolve] Skipping evolve because has no lucky egg.
2016-08-16 21:13:02,321 [CatchLuredPokemon] [INFO] [lured_pokemon_found] Lured pokemon at fort Upper Gun Battery (da2b433168cc4ab48b144ddbd6aedb29.16)
2016-08-16 21:13:03,961 [PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Tentacruel appeared! [CP 334] [Potential 0.53] [A/D/S 4/15/5]
2016-08-16 21:13:07,332 [PokemonCatchWorker] [INFO] [threw_berry] Threw a Razz Berry! Catch rate with Greatball is now: 52.41
2016-08-16 21:13:07,333 [PokemonCatchWorker] [INFO] [threw_pokeball] Used Greatball, with chance 52.41 (1 left)
2016-08-16 21:13:07,606 [PokemonCatchWorker] [INFO] [pokemon_caught] Captured Tentacruel! [CP 334] [Potential 0.53] [4/15/5] [+210 exp]
2016-08-16 21:13:07,921 [PokemonCatchWorker] [INFO] [gained_candy] You now have 609 Tentacool candy!
2016-08-16 21:13:12,960 [MoveToMapPokemon] [INFO] [move_to_map_pokemon_updated_map] Updated PokemonGo-Map to -33.8548861138, 151.208573886
2016-08-16 21:13:13,041 [MoveToMapPokemon] [INFO] [move_to_map_pokemon_move_towards] Moving towards Dragonair, 0.15km, left (8 minutes, 10 seconds)
2016-08-16 21:13:14,090 [IncubateEggs] [INFO] [next_egg_incubates] Next egg incubates in 0.31 km
2016-08-16 21:13:14,665 [MoveToMapPokemon] [INFO] [move_to_map_pokemon_move_towards] Moving towards Dragonair, 0.15km, left (8 minutes, 9 seconds)
2016-08-16 21:13:16,613 [MoveToMapPokemon] [INFO] [move_to_map_pokemon_move_towards] Moving towards Dragonair, 0.14km, left (8 minutes, 7 seconds)
2016-08-16 21:13:18,459 [MoveToMapPokemon] [INFO] [move_to_map_pokemon_move_towards] Moving towards Dragonair, 0.14km, left (8 minutes, 5 seconds)
2016-08-16 21:13:20,807 [CatchLuredPokemon] [INFO] [lured_pokemon_found] Lured pokemon at fort Former Officer's Quarters (c412a327f88f45a1979376acfb267108.16)
2016-08-16 21:13:22,314 [PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Magikarp appeared! [CP 10] [Potential 0.82] [A/D/S 12/14/11]
2016-08-16 21:13:25,626 [PokemonCatchWorker] [INFO] [threw_pokeball] Used Pokeball, with chance 100.00 (143 left)
2016-08-16 21:13:25,951 [PokemonCatchWorker] [INFO] [pokemon_caught] Captured Magikarp! [CP 10] [Potential 0.82] [12/14/11] [+210 exp]
2016-08-16 21:13:26,256 [PokemonCatchWorker] [INFO] [gained_candy] You now have 61 Magikarp candy!
2016-08-16 21:13:31,561 [ SpinFort] [INFO] [spun_pokestop] Spun pokestop Former Officer's Quarters. Experience awarded: 50. Items awarded: {u'Pokeball':

@Setsu-BHMT
Copy link

"any" and "logic" cannot be capitalized

@Tagada22
Copy link
Author

I try tha

"any": {"keep_best_iv": 2, "release_below_cp": 500, "release_below_iv": 0.9, "and"}

Error with configuration file

@Setsu-BHMT
Copy link

You're missing the "logic":

@Tagada22
Copy link
Author

Like that

"Logic": {"keep_best_iv": 2, "release_below_cp": 500, "release_below_iv": 0.9, "and"}

Because if use that

"any": {"keep_best_iv": 2, "release_below_cp": 500, "release_below_iv": 0.9, "and"}

Transfert not working

@dblinski
Copy link

dblinski commented Aug 16, 2016

"any": {"keep_best_iv": 2, "release_below_cp": 500, "release_below_iv": 0.9, "logic": "and"}

@Tagada22
Copy link
Author

I enter that

�"any": {"keep_best_iv": 2, "release_below_iv": 0.9, "logic": "and"}

But not transfer

_start] Starting bot...
2016-08-16 21:52:06,496 [CollectLevelUpReward] [INFO] [level_up_reward] Received level up reward: []
2016-08-16 21:52:06,497 [IncubateEggs] [INFO] [next_egg_incubates] Next egg incubates in 5.00 km
2016-08-16 21:52:06,497 [EvolvePokemon] [INFO] [skip_evolve] Skipping evolve because has no lucky egg.
2016-08-16 21:52:08,495 [PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Psyduck appeared! [CP 216] [Potential 0.44] [A/D/S 1/5/14]
2016-08-16 21:52:11,642 [PokemonCatchWorker] [INFO] [threw_pokeball] Used Pokeball, with chance 53.30 (147 left)
2016-08-16 21:52:11,980 [PokemonCatchWorker] [INFO] [pokemon_caught] Captured Psyduck! [CP 216] [Potential 0.44] [1/5/14] [+210 exp]
2016-08-16 21:52:12,244 [PokemonCatchWorker] [INFO] [gained_candy] You now have 31 Psyduck candy!
2016-08-16 21:52:17,971 [EvolvePokemon] [INFO] [pokemon_evolved] Successfully evolved Staryu with CP 107 and IV 0.38!
2016-08-16 21:52:41,817 [PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Staryu appeared! [CP 704] [Potential 0.42] [A/D/S 7/0/12]
2016-08-16 21:52:45,365 [PokemonCatchWorker] [INFO] [threw_berry] Threw a Razz Berry! Catch rate with Pokeball is now: 41.00
2016-08-16 21:52:45,366 [PokemonCatchWorker] [INFO] [threw_pokeball] Used Pokeball, with chance 41.00 (146 left)
2016-08-16 21:52:45,637 [PokemonCatchWorker] [INFO] [pokemon_caught] Captured Staryu! [CP 704] [Potential 0.42] [7/0/12] [+210 exp]
2016-08-16 21:52:45,916 [PokemonCatchWorker] [INFO] [gained_candy] You now have 257 Staryu candy!
2016-08-16 21:52:51,690 [EvolvePokemon] [INFO] [pokemon_evolved] Successfully evolved Staryu with CP 704 and IV 0.42!
2016-08-16 21:53:14,708 [PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Slowpoke appeared! [CP 115] [Potential 0.58] [A/D/S 6/15/5]
2016-08-16 21:53:17,688 [PokemonCatchWorker] [INFO] [threw_pokeball] Used Pokeball, with chance 78.21 (145 left)
2016-08-16 21:53:17,975 [PokemonCatchWorker] [INFO] [pokemon_caught] Captured Slowpoke! [CP 115] [Potential 0.58] [6/15/5] [+210 exp]
2016-08-16 21:53:18,227 [PokemonCatchWorker] [INFO] [gained_candy] You now have 30 Slowpoke candy!
2016-08-16 21:53:23,247 [MoveToMapPokemon] [INFO] [move_to_map_pokemon_updated_map] Updated PokemonGo-Map to -33.8563260523, 151.205641856
2016-08-16 21:53:23,320 [MoveToMapPokemon] [INFO] [move_to_map_pokemon_move_towards] Moving towards Dragonair, 0.90km, left (1 minute, 0 seconds

@Setsu-BHMT
Copy link

Do you have the TransferPokemon task defined?
Post your entire config

@smfbrooks
Copy link

@Tagada22 I don't think that this is achievable. #3005

@Tagada22
Copy link
Author

���������"evolve_speed": 20,
������������"use_lucky_egg": true
��������}
������},
������{
������� "type": "TransferPokemon"
������},
������{
������� "type": "RecycleItems",
��������"config": {

@dblinski
Copy link

@Tagada22
This is what I have in my config:

"release": {
"any": {"keep_best_iv": 1, "release_below_cp": 1000, "release_below_iv": 0.85, "logic": "and"},
"Dragonite": {"keep_best_iv": 3, "keep_best_cp": 3},
"Snorlax": {"keep_best_iv": 2, "keep_best_cp": 2},
"Arcanine": {"keep_best_iv": 2, "keep_best_cp": 1},
"Blastoise": {"keep_best_iv": 1, "keep_best_cp": 1},
"Charizard": {"keep_best_iv": 1, "keep_best_cp": 1},
"Eevee": {"keep_best_iv": 2, "keep_best_cp": 1},
"Exeggutor": {"keep_best_iv": 2, "keep_best_cp": 1},
"Golem": {"keep_best_iv": 1, "keep_best_cp": 1},
"Gyarados": {"keep_best_iv": 2, "keep_best_cp": 1},
"Lapras": {"keep_best_iv": 2, "keep_best_cp": 1},
"Muk": {"keep_best_iv": 1, "keep_best_cp": 1},
"Nidoking": {"keep_best_iv": 1, "keep_best_cp": 1},
"Nidoqueen": {"keep_best_iv": 2, "keep_best_cp": 1},
"Vaporeon": {"keep_best_iv": 2, "keep_best_cp": 1},
"Venusaur": {"keep_best_iv": 1, "keep_best_cp": 1},
"Dratini": {"keep_best_iv": 1, "keep_best_cp": 1},
"Dragonair": {"keep_best_iv": 1, "keep_best_cp": 1}
},

and this is output:
2016-08-16 14:30:52,125 [PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Krabby appeared! [CP 31] [Potential 0.71] [A/D/S 6/15/11]
2016-08-16 14:30:55,645 [PokemonCatchWorker] [INFO] [threw_pokeball] Used Pokeball, with chance 100.00 (244 left)
2016-08-16 14:30:55,848 [PokemonCatchWorker] [INFO] [pokemon_caught] Captured Krabby! [CP 31] [Potential 0.71] [6/15/11] [+150 exp]
2016-08-16 14:30:56,022 [PokemonCatchWorker] [INFO] [gained_candy] You now have 6 Krabby candy!
2016-08-16 14:31:02,347 [TransferPokemon] [INFO] [future_pokemon_release] Releasing Krabby [CP 31] [IV 0.71] based on rule: CP < 1000 AND IV < 0.85
2016-08-16 14:31:02,347 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Krabby, based on iv
2016-08-16 14:31:02,587 [TransferPokemon] [INFO] [pokemon_release] Exchanged Krabby [CP 31] [IV 0.71] for candy.
2016-08-16 14:31:19,665 [PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Goldeen appeared! [CP 12] [Potential 0.58] [A/D/S 8/4/14]
2016-08-16 14:31:23,316 [PokemonCatchWorker] [INFO] [threw_pokeball] Used Pokeball, with chance 100.00 (243 left)
2016-08-16 14:31:23,509 [PokemonCatchWorker] [INFO] [pokemon_caught] Captured Goldeen! [CP 12] [Potential 0.58] [8/4/14] [+120 exp]
2016-08-16 14:31:23,677 [PokemonCatchWorker] [INFO] [gained_candy] You now have 78 Goldeen candy!
2016-08-16 14:31:29,629 [TransferPokemon] [INFO] [future_pokemon_release] Releasing Goldeen [CP 12] [IV 0.58] based on rule: CP < 1000 AND IV < 0.85
2016-08-16 14:31:29,630 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Goldeen, based on iv
2016-08-16 14:31:29,899 [TransferPokemon] [INFO] [pokemon_release] Exchanged Goldeen [CP 12] [IV 0.58] for candy.
2016-08-16 14:32:04,952 [PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Psyduck appeared! [CP 72] [Potential 0.38] [A/D/S 13/3/1]
2016-08-16 14:32:08,629 [PokemonCatchWorker] [INFO] [threw_pokeball] Used Pokeball, with chance 92.71 (242 left)
2016-08-16 14:32:08,812 [PokemonCatchWorker] [INFO] [pokemon_caught] Captured Psyduck! [CP 72] [Potential 0.38] [13/3/1] [+100 exp]
2016-08-16 14:32:08,972 [PokemonCatchWorker] [INFO] [gained_candy] You now have 77 Psyduck candy!
2016-08-16 14:32:15,392 [TransferPokemon] [INFO] [future_pokemon_release] Releasing Psyduck [CP 72] [IV 0.38] based on rule: CP < 1000 AND IV < 0.85
2016-08-16 14:32:15,393 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Psyduck, based on iv
2016-08-16 14:32:15,644 [TransferPokemon] [INFO] [pokemon_release] Exchanged Psyduck [CP 72] [IV 0.38] for candy.

@Tagada22
Copy link
Author

I try with OR and not AND

I think its Working

016-08-16 23:06:02,615 [TransferPokemon] [INFO] [pokemon_release] Exchanged Psyduck [CP 183] [IV 0.31] for candy.
2016-08-16 23:06:06,443 [TransferPokemon] [INFO] [pokemon_release] Exchanged Psyduck [CP 297] [IV 0.4] for candy.
2016-08-16 23:06:08,456 [TransferPokemon] [INFO] [future_pokemon_release] Releasing Poliwrath [CP 1480] [IV 0.38] based on rule: CP < 0 OR IV < 0.9
2016-08-16 23:06:08,456 [TransferPokemon] [INFO] [future_pokemon_release] Releasing Poliwrath [CP 1093] [IV 0.36] based on rule: CP < 0 OR IV < 0.9
2016-08-16 23:06:08,456 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Poliwrath, based on iv
2016-08-16 23:06:08,797 [TransferPokemon] [INFO] [pokemon_release] Exchanged Poliwrath [CP 1480] [IV 0.38] for candy.
2016-08-16 23:06:12,119 [TransferPokemon] [INFO] [pokemon_release] Exchanged Poliwrath [CP 1093] [IV 0.36] for candy.
2016-08-16 23:06:15,872 [TransferPokemon] [INFO] [future_pokemon_release] Releasing Seaking [CP 26] [IV 0.38] based on rule: CP < 0 OR IV < 0.9
2016-08-16 23:06:15,873 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Seaking, based on iv
2016-08-16 23:06:16,243 [TransferPokemon] [INFO] [pokemon_release] Exchanged Seaking [CP 26] [IV 0.38] for candy.
2016-08-16 23:06:19,579 [TransferPokemon] [INFO] [future_pokemon_release] Releasing Starmie [CP 1713] [IV 0.42] based on rule: CP < 0 OR IV < 0.9
2016-08-16 23:06:19,580 [TransferPokemon] [INFO] [future_pokemon_release] Releasing Starmie [CP 216] [IV 0.64] based on rule: CP < 0 OR IV < 0.9
2016-08-16 23:06:19,580 [TransferPokemon] [INFO] [future_pokemon_release] Releasing Starmie [CP 265] [IV 0.38] based on rule: CP < 0 OR IV < 0.9
2016-08-16 23:06:19,580 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Starmie, based on iv
2016-08-16 23:06:19,899 [TransferPokemon] [INFO] [pokemon_release] Exchanged Starmie [CP 1713] [IV 0.42] for candy.
2016-08-16 23:06:22,483 [TransferPokemon] [INFO] [pokemon_release] Exchanged Starmie [CP 216] [IV 0.64] for candy.
2016-08-16 23:06:25,061 [TransferPokemon] [INFO] [pokemon_release] Exchanged Starmie [CP 265] [IV 0.38] for candy.
2016-08-16 23:06:29,415 [MoveToMapPokemon] [INFO] [move_to_map_pokemon_updated_map] Updated PokemonGo-Map to -33.8610573231, 151.221269479

@Tagada22
Copy link
Author

My bot crash :/

in()
File "pokecli.py", line 104, in main
bot.tick()
File "/home/PokemonGo-Bot/pokemongo_bot/init.py", line 498, in tick
if worker.work() == WorkerResult.RUNNING:
File "/home/PokemonGo-Bot/pokemongo_bot/cell_workers/move_to_map_pokemon.py", line 248, in work
pokemon_list = self.get_pokemon_from_map()
File "/home/PokemonGo-Bot/pokemongo_bot/cell_workers/move_to_map_pokemon.py", line 147, in get_pokemon_from_map
if pokemon['dist'] > ((pokemon['expire'] - now) * mean_walk_speed) and not self.config['snipe']:
KeyError: 'expire'

You think its Provide to the new config ?

@Tagada22
Copy link
Author

Same problems with my old config

I open new issue and close this

Thanks bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants