Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokestop Limit Discussion #4194

Closed
BreezeRo opened this issue Aug 18, 2016 · 14 comments
Closed

Pokestop Limit Discussion #4194

BreezeRo opened this issue Aug 18, 2016 · 14 comments

Comments

@BreezeRo
Copy link
Contributor

Was able to get a working example of pokemon catch limits and database logging in #4188 based on database/migrations implementation by @cwild starting in #4129, personally I'm pretty content with the logic there.

What I'm wondering now is how do you guys think the pokestop limit should be handled? Assuming pokestops are logged to the database as the catch logs are, we can easily query the data to grab stops made in the past 24 hours, and count them. If the count is higher than config.pokestop_daily_limit, what should we do?

  • Shut the bot down
  • Put it to sleep for a period of time
  • Kill the bot
  • Stop spinning stops but keep catching

I'd really appreciate some ideas, input (including on the logic)

@celinereine
Copy link

Honestly, there are enough configurations currently with catch delays that the bot can really slow down to a human level. Just increase the delays and decrease the walk speed. It'd be impossible to even reach the ban limit.

@mjmadsen
Copy link
Contributor

What I would like to see down the road, is we run an account until we meet user defined limits. Then we switch to the next account on file and repeat the process.

@BreezeRo
Copy link
Contributor Author

That's a good idea @mjmadsen, noted

@RedViper9
Copy link
Contributor

I propose that both the pokestop limit and the pokemon catch limit could be controlled implicitly by providing a maximum walk distance +/- some randomization. The odds of a city dweller walking 30+km per day multiple days per week are fairly low, I think.

Such a limit should also make it fairly simple for the bot to "go home" as some users have requested. No human input (or catching there of) needed.

Thoughts?

@MerlionRock
Copy link
Contributor

@RedViper9 Good Idea. Perhaps a new variable call HomeLocation? Once reached % of userdefined_limit , it will walk home and inactive for a user defined hrs?

@ingcrengifo
Copy link

some example of settings account ??? They have already banned me :( 2 counts that I have wrong in my config

@rawgni
Copy link
Contributor

rawgni commented Aug 18, 2016

How do you make sure the user do not login to the bot (using other bot, snipping app or the mobile app) and do things that may skew the data.

Regarding the question, I think it's better if there is a way to randomly throttle the bot behaviour such that it never reaches the limit. However, if it does reach the limit, killing it will be great after doing some stuff (randomly pick a few), such as:

  • checking out profile page
  • checking out items
  • checking out shop
  • walk for awhile (passing pokestops and/or pokemons)
  • stop (not moving or catch pokemon) for awhile
  • evolve/transfer/rename/favourite

Assume that the code get the bot to do X after hitting the limit, this will be repeated or seen across multiple bots. Suspicious.

@BreezeRo
Copy link
Contributor Author

Good point @rawgni in regard to walking without activity + the bot hitting the same limit on multiple accounts (could especially be obvious if originating from the same IP using other similar variables in config). Perhaps the limit could be offset a little bit (like the mix/max walk values).

@RedViper9 as for returning home in this way, that's a good idea as well - it could even be incorporated into the sleep task in a way that the distance between current position and home could be calculated with the speed variables to send the user home with just enough time before sleep is enabled. So if the bot goes to sleep in 30 minutes and it takes 25 minutes to get home it would stop all activity at that period to make it home "on time"

@NatNew0
Copy link

NatNew0 commented Aug 18, 2016

Another point might be that people usually follow the streets ;-)
The bot seems to go through buildings, rivers and so on.
This could possibly be analyzed from the userdata in the database.
If you have an unrealistic walking path that might trigger a ban.

@RedViper9
Copy link
Contributor

@rawgni I think that the user using different applications is not and should not be our concern. That's the user's responsibility. If you know you want to play on your phone later, set the bot's limit to 2/3 normal distance.

I do not think that people using sniping apps are concerned with humanization of the bot, which would be the main goal of using implicit limit rather than explicit limits.

That said, we can manage users switching among different config files in our bot by having the distance traveled since (time) be logged as part of the last-location file.

@alexyaoyang
Copy link
Contributor

alexyaoyang commented Aug 18, 2016

Great job on the Pokemon limitation!

Stopping all the bot at a fixed number daily is suspicious too. We should randomize based on user provided offset or min/max. Same goes for the daily catch limit which has been merged.

@MerlionRock
Copy link
Contributor

Suggestion: Add a % randomness to values that need variance? So that every bot across all user will not seem have a fix routine. Optional but default to true?

@Gurzeh
Copy link
Contributor

Gurzeh commented Aug 19, 2016

@RedViper9 what is the limit on Pokestop visited?

This was referenced Aug 19, 2016
@k4n30
Copy link
Contributor

k4n30 commented Aug 30, 2016

#4906

@k4n30 k4n30 closed this as completed Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests