Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot Print "This is a VIP pokemon. Catch!!!" even low stat pokemon. #4665

Closed
razithekillers opened this issue Aug 24, 2016 · 11 comments
Closed

Comments

@razithekillers
Copy link

Expected Behavior

IV below 0.8 Should not VIPs

Actual Behavior

All pokemon catching is stated VIPs

Your FULL config.json (remove your username, password, gmapkey and any other private info)

http://pastebin.com/kFwE76zv

Output when issue occurred

image

Steps to Reproduce

Should not print "This is a VIP pokemon. Catch!!!" If IV below 0.8

Other Information

OS:
Ubuntu On Windows
Branch:
Master
Git Commit:

Python Version:

Any other relevant files/configs (eg: path files)

Short Description

Possible solution

How it would help others

@Bashin
Copy link
Contributor

Bashin commented Aug 24, 2016

"treat_unseen_as_vip": true,
in your config.. set this to false

@razithekillers
Copy link
Author

@Bashin Thanks, :D

@kenkclam
Copy link

kenkclam commented Aug 24, 2016

I have the same problem:

2016-08-24 11:17:44,589 [PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Poliwag appeared! [CP 10] [NCP 0.01] [Potential 0.58] [A/D/S 7/11/8]
2016-08-24 11:17:47,591 [PokemonCatchWorker] [INFO] [vip_pokemon] This is a VIP pokemon. Catch!!!
2016-08-24 11:17:50,377 [PokemonCatchWorker] [INFO] [threw_pokeball] OK throw! Used Pokeball, with chance 100.00 (85 left)
2016-08-24 11:17:50,598 [PokemonCatchWorker] [INFO] [pokemon_caught] Captured Poliwag! [CP 10] [NCP 0.01] [Potential 0.58] [7/11/8] [+100 exp]

As you can see, poliwag is not an unseen pokemon [+100 exp] not [+600 exp]
the bot still define it as VIP

maybe if the pokemon has higher cp/iv than what I have in the bag, the bot will call it VIP?
I have not found such a setting in the config file wiki page.

@maxprzemo
Copy link

@kenkclam
read what he wrote @Bashin

  • treat_unseen_as_vip: Default "true" | Set to "false" to disable treating pokemons you don't have in your pokedex as VIPs.

@davidspeijer
Copy link

Could it be that;
bot starts and capture first Poliwag but doesn't update the captured pokemon? So next time it sees a Poliwag without a restart that it is still treaded as a VIP?

@sohje
Copy link
Contributor

sohje commented Aug 24, 2016

@kenkclam Show us your config.
@davidspeijer Just started a new bot. First Rattata treated as VIP, second one - as normal pokemon. So pokedex updated correctly. Same for Pidgeys.

@k4n30
Copy link
Contributor

k4n30 commented Aug 24, 2016

@Calcyfer - Can you look into please as this was your PR

@k4n30 k4n30 added the Bug label Aug 24, 2016
@glennvgastel
Copy link
Contributor

@k4n30 My PR only added the config value, the actual logic was added by @sohje in PR #4580 .
The config value seems to work, so I'd look into the logic direction.

@sohje
Copy link
Contributor

sohje commented Aug 24, 2016

@Calcyfer @k4n30 I made tests before and review code - dont see any problems with logic or code.
Need more logs and bots configs where problem accurs.

@glennvgastel
Copy link
Contributor

@kenkclam A small reminder to show us your config, please.

@mjmadsen
Copy link
Contributor

Since @razithekillers issue has been solved, please open up a new issue if you have problems (with configs and logs!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants