Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot would not keep Greatball #5331

Closed
xSkav opened this issue Sep 9, 2016 · 5 comments
Closed

Bot would not keep Greatball #5331

xSkav opened this issue Sep 9, 2016 · 5 comments

Comments

@xSkav
Copy link

xSkav commented Sep 9, 2016

Expected Behavior

Having my item filter to keep greatball at an amount .

Actual Behavior

Bot not keeping any Greatball

Your FULL config.json (remove your username, password, gmapkey and any other private info)

http://pastebin.com/5ucCQY5N

Output when issue occurred

[2016-09-09 14:41:06] [MainThread] [UpdateLiveInventory] [INFO] Pokemon: 244/250 | Items: 314/350 | Pokeballs: 134 | GreatBalls: 0 | UltraBalls: 122 | RazzBerries: 14 | LuckyEgg: 6

Steps to Reproduce

Other Information

OS: Windows 10 64 bit

Branch: dev

Git Commit:

Python Version: Python 2.7.12

Any other relevant files/configs (eg: path files)

@julienlavergne
Copy link
Contributor

There is no parameter that exist today to keep a minimum number of items. The parameter define a maximum number of items.

@kureijir
Copy link

kureijir commented Sep 9, 2016

Set "max_balls_keep" to, for example 200, then remove everything in "item_filter", and it will keep best 200 balls.

  {
    "type": "RecycleItems",
    "config": {
      "enabled": true,
      "min_empty_space": 13,
      "max_balls_keep": 200,
      "max_potions_keep": 20,
      "max_berries_keep": 50,
      "max_revives_keep": 20,
      "item_filter": {},
      "recycle_wait_min": 3,
      "recycle_wait_max": 5,
      "recycle_force": true,
      "recycle_force_min": "00:01:00",
      "recycle_force_max": "00:05:00"
    }
  },

@mmixx
Copy link

mmixx commented Sep 10, 2016

@xSkav Hmmm... by looking at your settings... you should lower the value of how much Pokeballs you want to keep (eg. 100 or 50)... on your post above... you have 134 Pokeballs... if you lower the value to just 50, it will just keep 50 Pokeballs and will have space for other types of pokeballs...

@xSkav
Copy link
Author

xSkav commented Sep 11, 2016

mmixx . i actually only put 20 pokeball to keep . but its still doesnt keep any greatball . so i run out of pokeballs to catch . so i switch it back to higer pokeball amount

@alexyaoyang
Copy link
Contributor

alexyaoyang commented Sep 16, 2016

@xSkav Like @anakin5 said, the keep value in item_filter means the # of that item to keep when Recycling Items, not the minimum # of that item the bot will save for you.

Unfortunately, this is an expected pattern as your account level levels up (higher level account encounters higher level pokemon).

This issue can be closed if @xSkav has no more questions.

@k4n30 k4n30 closed this as completed Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants