Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nickname does not work for 2 conditions #5654

Closed
abhinavagrawal1995 opened this issue Sep 24, 2016 · 3 comments
Closed

Nickname does not work for 2 conditions #5654

abhinavagrawal1995 opened this issue Sep 24, 2016 · 3 comments

Comments

@abhinavagrawal1995
Copy link

abhinavagrawal1995 commented Sep 24, 2016

Expected Behavior

      "nickname_above_iv": 0.8,
      "nickname_above_cp": 1500,

Expecting all pokemon above 1500 cp OR above 0.8 iv to be nicknamed

Actual Behavior

Only pokemon above 0.8 iv nicknamed. Regardless of CP. (below 1500 also nicknamed if iv>0.8

{
"type": "NicknamePokemon",
"config": {
"enabled": true,
"nickname_above_iv": 0.8,
"nickname_above_cp": 1500,
"nickname_template": "{iv_pct}-{attack_code}-{name}",
"nickname_wait_min": 3,
"nickname_wait_max": 5
}
},

@Gobberwart
Copy link
Contributor

nickname_above_cp is not supported by NicknamePokemon task.

@abhinavagrawal1995
Copy link
Author

In that case, this please reopen as feature request

@Gobberwart
Copy link
Contributor

Please resubmit as feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants