Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen 2 #5913

Closed
saliapin opened this issue Feb 17, 2017 · 8 comments
Closed

Gen 2 #5913

saliapin opened this issue Feb 17, 2017 · 8 comments

Comments

@saliapin
Copy link

So, Gen 2 is out, at long last! The bot has been catching the new 'mons, but of course their movesets are not in the database. Any word on an update? How long do you think we can safely use the bot before the old version stop working? Cheers!

@saliapin
Copy link
Author

OK, now I'm getting errors that might be caused by the missing movesets:

File "/Users/xxx/PokemonGo-Bot/pokemongo_bot/inventory.py", line 652, in data_for
attack_id, cls.name))
ValueError: Attack 281 not found in FastAttacks
[2017-02-16 17:16:20] [sentry.errors] [ERROR] Sentry responded with an error: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128) (url: https://app.getsentry.com/api/90254/store/)

Can we turns off the routine that checks the attacks?

@camnomis
Copy link

To be fair there are so many changes that running it now would be pointless, issues with berries etc, new Pokémon and move sets, the API has been depricayed already it seems so I wouldn't advise using the bot.

Although why would you want to bot now, this is when the game is fun again!

@MerlionRock
Copy link
Contributor

MerlionRock commented Feb 17, 2017

Exactly! But don't worry, API will updated soon. Hashing service for 0.57.2 is already in service. It's only for PGoAPI to update some of their values.

But this bot will need to have quite a few changes. So be slightly patience.

@pogarek
Copy link
Contributor

pogarek commented Feb 17, 2017

files :

  • data/pokemon.json
  • fast_moves.json
    will need to be updated for gen2. please feel free to do it (in your fork or attach it here).

@MerlionRock
Copy link
Contributor

MerlionRock commented Feb 17, 2017

If developer wants to help, you can use my fork of PGoAPI here: https://github.com/MerlionRock/pgoapi/tree/develop

Just take note protos are not updated to 0.57 yet
Update: In requirement.txt, change pgoapi to
git+https://github.com/MerlionRock/pgoapi.git@develop#egg=pgoapi

Update 2: Official PGoAPI has been updated to 0.57.2 Just do an update, no need to use my fork.

@MerlionRock
Copy link
Contributor

for the new item support, here are their values:

"1101": "Sun Stone",
"1102": "Kings Rock",
"1103": "Metal Coat",
"1104": "Dragon Scale",
"1105": "Upgrade"

@pogarek
Copy link
Contributor

pogarek commented Feb 17, 2017

In the past (when 0.53 got released and gen2 got added to pokedex) I've used below to create pokemon.json

If you know a better , correct sources, with all the data that we need (check the content of data/pokemon.json file), then let me know. I'll write a script , which will generate the new json file.

Or just update the existing files that we have, if these changes are minor.

@pogarek
Copy link
Contributor

pogarek commented Feb 17, 2017

closing, as duplicate of #5914 . Let's continue there

@pogarek pogarek closed this as completed Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants