Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "check_niantic_api" to false, fix candies names #5862

Merged
merged 3 commits into from
Jan 11, 2017
Merged

Change "check_niantic_api" to false, fix candies names #5862

merged 3 commits into from
Jan 11, 2017

Conversation

Jcolomar
Copy link
Contributor

Please Note - You may remove this section before opening your PR

We receive lots of PRs and it is hard to give proper review to PRs. Please make it easy on us by following these guidelines:

  1. We do not accept changes to master. Please make sure your pull request is aimed at dev.
  2. If you changed a bunch of files (that aren't config files) or multiple workers to implement your feature, it probably won't get proper attention. Please split it up into multiple, smaller, more focused, and iterative PRs if you can.
  3. If you are adding a config value to something, make sure you update the appropriate config.json example files.
  4. If your pull request is fixing / resolving / or closing any of the issues, please ensure the correct syntax is used eg: Closes #X, Fixes#Y

Short Description:

Fixes/Resolves/Closes (please use correct syntax):

@mention-bot
Copy link

@Jcolomar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @eRobot1, @AdaptCharm and @solderzzc to be potential reviewers.

@Jcolomar Jcolomar changed the title Change "check_niantic_api" to false Change "check_niantic_api" to false, fix candies names Jan 10, 2017
@solderzzc
Copy link
Contributor

solderzzc commented Jan 11, 2017 •
edited by douglascamata
Loading

👍

Approved with PullApprove

@solderzzc solderzzc merged commit acd4377 into PokemonGoF:dev Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jcolomar @mention-bot @solderzzc