Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URGENT: Integration with PokeData #67

Closed
gyachdav opened this issue Oct 14, 2016 · 7 comments
Closed

URGENT: Integration with PokeData #67

gyachdav opened this issue Oct 14, 2016 · 7 comments
Assignees
Labels

Comments

@gyachdav
Copy link

This issue is a status update request and an urgent call to complete the integration with project A so we can move ahead with the launch.

Please make here a task list and tick completed steps so we will know what is needed in order to complete this integration.

@semioniy @bensLine @MatthiasBaur @Aurel-Roci

@Aurel-Roci
Copy link
Collaborator

Aurel-Roci commented Oct 14, 2016

Since we are going to provide a npm package for the predictions, what is needed from team A is adding java in the docker container, since we are using java to run the weka file for the predictions.

  • Add Java to the Docker Container
  • Add the prediction package in the dependencies

@jonas-he
Copy link

Java is done. Apart from that only adding a dependency is not gonna cut it right? we'll need to add a new API route, which then listens on prediction requests and calls something like a predict(lat, lng, timestamp) function from your package. However i didnt find such in the description here https://www.npmjs.com/package/predict-pokemon

@Aurel-Roci
Copy link
Collaborator

Thanks for letting me know, I will add that to the description. You can find it here the way it works. PokemonGoers/PokeData#183

@bensLine
Copy link
Collaborator

@jonas-he fyi, we have to adapt the URL when the 6GB database is available. Besides, you need to unzip the json/pokestop_groups.7z file in the prediction npm package in order to use it. And it takes a while to initialize the module.

@gyachdav
Copy link
Author

It has been 13 days since this issue was open with the label URGENT and the last response here is 10 days old... We need an answer here about status ASAP! aka As Soon As Possible! 😡

@PokemonGoers/pokedata

@Aurel-Roci
Copy link
Collaborator

@gyachdav The only reason this issue is kept open, is so that if team A has any further questions on the predictions the can ask here. The integration is done.

@gyachdav
Copy link
Author

This is not how it should be handled. If this is done then the issue is closed. If project A has some questions they are welcome to open a new issue label it "questions" and reference this issue if needed.

Now, if this is done - is there a demo where we can see the integration actually working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants