Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differences between API data and data from this repo #483

Open
Cealgair opened this issue Sep 17, 2023 · 1 comment
Open

Differences between API data and data from this repo #483

Cealgair opened this issue Sep 17, 2023 · 1 comment

Comments

@Cealgair
Copy link
Contributor

Cealgair commented Sep 17, 2023 •
edited
Loading

Comparing card data I got from the API with data currently in the master branch, I have found the following differences:

  • cards swshp-SWSH285 and swshp-SWSH286 are missing on GitHub. This is addressed by Added SWSH285, SWSH286 to swshp.json #458
  • card sv1-256 is missing the artist on the API, while it has the correct artist on GitHub

I did not check any set data, but there are already a couple of open issues about that, namely #460 and #461
@Cealgair
Copy link
Contributor Author

@adback03 it seems like the changes made by #499 and #503, as well as those made to base2.json by #473, are not reflected in the api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cealgair