Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new UI to manage natures and changes the data structure of the natures #386

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

Add a new UI to manage natures and changes the data structure of the natures #386

wants to merge 9 commits into from

Conversation

Palbolsky
Copy link
Collaborator

@Palbolsky Palbolsky commented Sep 6, 2024 •
edited
Loading

Description

This PR adds the natures UI and changes the data structure of the natures. (#327)
In draft because the changes have not been applied to PSDK.

Before, natures were considered to be a configuration. Now they are entities.
The new structure of a nature (example with the adamant nature):

{
  "klass": "Nature",
  "id": 3,
  "dbSymbol": "adamant",
  "stats": {
    "atk": 110,
    "dfe": 100,
    "spd": 100,
    "ats": 90,
    "dfs": 100
  },
  "flavors": {
    "liked": "spicy",
    "disliked": "dry"
  }
}

Values authorised for the flavors: spicy, dry, sweet, bitter, sour, none.
The nature entities can be found in Data/Studio/natures folder.

Note before testing

I recommand to create a new project or to have a versioned project (git) to test.

Tests to perform

  • The migration to convert nature config to nature entities works ;
  • The user can create a nature ;
  • The user can delete a nature ;
  • The user can edit a nature ;
  • The user can use a nature in the quest objective condition and a Pokémon of a trainer ;
  • PSDK works correctly with the data changes (can not be tested currently)

Screenshots

image

@Palbolsky Palbolsky added the user story Issues related to a new feature or request label Sep 6, 2024
@Palbolsky Palbolsky self-assigned this Sep 6, 2024
@Palbolsky Palbolsky linked an issue Sep 6, 2024 that may be closed by this pull request
Create a new UI to manage Natures #327
Open
AerunDev
AerunDev approved these changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@AerunDev AerunDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testé et nickel pour la partie Studio ! 😄

Restera à ajouter les modifications côté Pokémon SDK, vu avec @pw-rey sur cette partie.

AntoinePoree
AntoinePoree approved these changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@AntoinePoree AntoinePoree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je t'ai fait un retour sur un changement de label qui n'importe peu. Je te l'approve quand même vu le changement.
Bo beaulot!

src/views/components/database/dataBlocks/DataFieldgroupField.tsx Show resolved Hide resolved
@pw-rey
Copy link
Collaborator

pw-rey commented Sep 10, 2024

Travail démarré côté PSDK à l'instant même. Petit point de détail qui peut être modifié à tout moment concernant les clés relatives aux saveurs : il faudrait peut-être privilégier "liked" et "disliked" pour reste raccord avec les termes utilisés sur Bulbapedia notamment et sur d'autres sites. Ca évitera aussi que l'on utilise "favourite" qui peut être écrit ainsi en anglais britannique VS "favorite" en anglais américain, vu que "liked" et "disliked" n'ont qu'une seule écriture. 😄

@Palbolsky
Copy link
Collaborator Author

Travail démarré côté PSDK à l'instant même. Petit point de détail qui peut être modifié à tout moment concernant les clés relatives aux saveurs : il faudrait peut-être privilégier "liked" et "disliked" pour reste raccord avec les termes utilisés sur Bulbapedia notamment et sur d'autres sites. Ca évitera aussi que l'on utilise "favourite" qui peut être écrit ainsi en anglais britannique VS "favorite" en anglais américain, vu que "liked" et "disliked" n'ont qu'une seule écriture. 😄

J'ai changé le nom des clés. :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AerunDev AerunDev AerunDev approved these changes

@AntoinePoree AntoinePoree AntoinePoree approved these changes

Assignees

@Palbolsky Palbolsky

Labels
user story Issues related to a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a new UI to manage Natures
4 participants
@Palbolsky @pw-rey @AerunDev @AntoinePoree