Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the interface of loading defaults to make it more compact! #31

Closed
ZPYin opened this issue Apr 19, 2020 · 1 comment · Fixed by #32
Closed

Revise the interface of loading defaults to make it more compact! #31

ZPYin opened this issue Apr 19, 2020 · 1 comment · Fixed by #32
Assignees
Labels
enhancement New feature or request

Comments

@ZPYin
Copy link
Collaborator

ZPYin commented Apr 19, 2020

@HolgerPollyNet

The reasons for making the changes are twofold:

  1. Defaults and polly configs can be backup together. This is very convenient to setup a new development environment.
  2. Configuring the pollynet_processing_chain_link.txt becomes easier, as only the polly defaults file name needs to be provided, compared with setting a new matlab function for loading the defaults.
@ZPYin ZPYin self-assigned this Apr 19, 2020
@ZPYin ZPYin added the enhancement New feature or request label Apr 19, 2020
@ZPYin
Copy link
Collaborator Author

ZPYin commented Apr 19, 2020

New folder structure of config is as below:

config
├── pollyConfigs
│   └──  polly_global_config.json
├── pollyDefaults
│   ├── template_polly_defaults.json
│   ├── template_polly_overlap_355.txt
│   └── template_polly_overlap_532.txt
├── template_pollynet_processing_chain_config.json
└── template_pollynet_processing_chain_link.txt

Meanwhile, only the polly defaults filename needs to be provided in configuring the pollynet_processing_chain_config_link.txt.

Before

pollyxt_tau,2019-09-10 00:00:00,2019-11-03 23:59:59,pollyxt_tau_config_20190910.json,pollynet_processing_chain_pollyxt_tau.m,Move to Tel Aviv Israel,pollyxt_tau_read_defaults.m

After

pollyxt_tau,2019-09-10 00:00:00,2019-11-03 23:59:59,pollyxt_tau_config_20190910.json,pollynet_processing_chain_pollyxt_tau.m,Move to Tel Aviv Israel,pollyxt_tau_defaults.json

@ZPYin ZPYin closed this as completed Apr 19, 2020
@ZPYin ZPYin linked a pull request Apr 19, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant