Replies: 2 comments 1 reply
-
This seems like a good idea, though I'd want to wait for some current PRs to be merged before making global style changes like this. Personally I'd prefer to remove semi-colons (most of the time they're not needed) and set tab size to 2 (horizontal space is precious). |
Beta Was this translation helpful? Give feedback.
1 reply
-
Done in d2de89b :) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
👋 Hello folks, I was wondering if there any plans to implement Prettier or any other linters? If not, I'd like to suggest the use of Prettier to standardize the codebase style. I noticed that there were some inconsistencies in styling (e.g. double quote vs. single, semicolons randomly missing, etc.).
I believe it would add value to the project as a whole -- having a standardized style can help greatly in open-source projects, as it allows developers to focus on code, and not direct cognitive efforts towards things like remembering to add a double quote vs a single quote. Not to mention the benefits of auto-formatting which results in an (arguably) cleaner codebase.
There are certainly arguments against adding Prettier as well; I have been in situations with large codebases in which Prettier gets in the way sometimes, but mostly due to overly specific styling rules. Would love to hear any thoughts on this.
I was able to get this up and running locally, running Prettier on the whole codebase (.tsx, .js files only):
Commit that shows prettier setup <- Rules can be easily modified and applied
Commit that shows result of running prettier
Beta Was this translation helpful? Give feedback.
All reactions