Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe try to convert NodeProcess into an Interface for easier implementation #76

Open
n-peugnet opened this issue Jun 18, 2020 · 1 comment
Labels
disscussion This issue needs discussion enhancement Improvements to already existing features
Milestone

Comments

@n-peugnet
Copy link
Collaborator

I am not sure yet if this will be better with an interface than with an abstract class but we can try.

@n-peugnet n-peugnet added enhancement Improvements to already existing features disscussion This issue needs discussion labels Jun 18, 2020
@n-peugnet n-peugnet added this to the v1.0 milestone Jul 8, 2020
@n-peugnet
Copy link
Collaborator Author

After some thinking, we should

  1. add two interfaces:
    • Infrastructure
    • NodeProcess
  2. rename the current Infrastructure and NodeProcess into AbstractInfrastructure and AbstractNodeProcess
  3. finally try to remove AbstractNodeProcess by removing the infra property and accessing the current Infrasctructure through a static method in Ppi (e.g. Ppi.infra())

The problem with (3.) is that, currently, I think (but not sure) PeersimInfrastructure is cloned so that each NodeProcess has its own instance. Anyway this could be changed as it could work with only one instance of PeersimInfrastructure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disscussion This issue needs discussion enhancement Improvements to already existing features
Projects
None yet
Development

No branches or pull requests

1 participant