Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Mint and Burn events to match OpenZeppelin #565

Closed
wjmelements opened this issue Feb 21, 2019 · 3 comments
Closed

Rename Mint and Burn events to match OpenZeppelin #565

wjmelements opened this issue Feb 21, 2019 · 3 comments

Comments

@wjmelements
Copy link

The OpenZeppelin token uses events called Mint and Burn, analogous to your Minted and Burnt. The scheme is also used by TrueUSD. Adopting their naming scheme would facilitate compatibility.

@maxsam4
Copy link
Contributor

maxsam4 commented Feb 21, 2019

@wjmelements Thanks for looking into our codebase!

In our latest dev branch (dev-3.0.0) we have decided to use event names set in IERC1400 family. More specifically, Minted is now Issued and Burned is now Redeemed. These are part of IERC1594 and we believe that they represent the Security token use case better.

@wjmelements
Copy link
Author

Thanks for your reply. If EIP1594 goes through, we may consider upgrading our events to match. Thanks for caring about open standards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants