Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Styling local DOM #1185

Closed
ebidel opened this issue Jun 12, 2015 · 2 comments
Closed

Styling local DOM #1185

ebidel opened this issue Jun 12, 2015 · 2 comments

Comments

@ebidel
Copy link
Contributor

ebidel commented Jun 12, 2015

From @Scratch2k on June 12, 2015 0:4

I've just spent several hours trying to figure out why I couldn't apply a theme to my components with cross scope styling with css variable.

The documentation at: https://www.polymer-project.org/1.0/docs/devguide/styling.html outlines the basics and I followed it to the letter. It just wasn't working. The sample code shows the class definitions using css variables, like so:

   <style>
      .title {
        color: var(--my-toolbar-title-color);
      }
    </style>

and

 <style>
    .title{
      --my-toolbar-title-color: green;
    }
  </style>

and I followed this syntax, it wasn't until I stumbled upon the API reference (http://polymer.github.io/polymer/) which showed the following syntax:

 <style is="custom-style">
    .title{
      --my-toolbar-title-color: green;
    }
  </style>

Then everything magically worked!

Could I recommend the docs be updated with the requirement for <style is="custom-style"> for css variables shim to work?

Copied from original issue: Polymer/polymer#1842

@ebidel
Copy link
Contributor Author

ebidel commented Jun 12, 2015

Hey @Scratch2k, the relevant section on that page is Custom element for document styling (custom-style, although it's pretty far down on that doc. The idea is that within and element, polymer takes care of shimming styles in <style>. Outside, you need to tell Polymer what styles to shim using <style is="custom-style">.

@Scratch2k
Copy link

I see it now, thanks for taking the time to reply Eric.

@ebidel ebidel closed this as completed Jun 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants