Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Not a BUG - FYI: Update tutorial - core-icon-button #631

Closed
tjsavage opened this issue Sep 2, 2014 · 1 comment
Closed

Not a BUG - FYI: Update tutorial - core-icon-button #631

tjsavage opened this issue Sep 2, 2014 · 1 comment

Comments

@tjsavage
Copy link
Contributor

tjsavage commented Sep 2, 2014

NOT A BUG - Just an FYI

In http://www.polymer-project.org/docs/start/tutorial/step-4.html#edit-post-cardhtml, there are instructions to add styling for the post-card.html file that includes "fill" attributes to change color whenever the "favorite" button is clicked.
It must say "color" instead:

CURRENT:

core-icon-button {
  position: absolute;
  top: 3px;
  right: 3px;
  fill: #636363;
}
:host([favorite]) core-icon-button {
  fill: #da4336;
}

IT MUST BE:

core-icon-button {
  position: absolute;
  top: 3px;
  right: 3px;
  color: #636363;
}
:host([favorite]) core-icon-button {
  color: #da4336;
}

Also, the polymer files distributed within the tutorial should be updated with the latest version distributed in github.

@arthurevans
Copy link

Fixed by the recent updates to the tutorial. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants