Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

changes in my-app.html breaks polymer-starter-kit (2.0-preview) in IE11 #1020

Closed
LawrenceMok opened this issue May 27, 2017 · 2 comments
Closed

Comments

@LawrenceMok
Copy link

LawrenceMok commented May 27, 2017

I've identified that after the addition (0b67b51) of this part of code in src/my-app.html, polymer-starter-kit (2.0-preview) failed to work in IE11 when run with polymer serve:

   constructor() {
        super();

        // Get root pattern for app-route, for more info about `rootPath` see:
        // https://www.polymer-project.org/2.0/docs/upgrade#urls-in-templates
        this.rootPattern = (new URL(this.rootPath)).pathname;
      }

To be specific, this line caused the problem and when commented out, it works:
this.rootPattern = (new URL(this.rootPath)).pathname;

@LawrenceMok LawrenceMok changed the title changes in my-app.html breaks polymer-starter-kit (2.0-preview) changes in my-app.html breaks polymer-starter-kit (2.0-preview) in IE11 May 27, 2017
LawrenceMok referenced this issue May 27, 2017
…eployment (#995)

* Use relative paths with <base> and rootPath

* Fix 404 view, add missing semi-colon

* Remove unneeded rootPath bindings

* Improve commenting on `base` tag for relative paths

* Fix `manifest.json` for subdirectory deployment

* Add note about `rootPath`, linking to documentation

* Fix line length to pass lint
@jsilvermist
Copy link
Contributor

This is caused because IE11 doesn't support using new URL(...).pathname, updated to use alternative method for IE11 in #1021. Thanks for pointing this out @LawrenceMok!

@abdonrd
Copy link
Contributor

abdonrd commented Jun 1, 2017

Fixed by #1021!

@abdonrd abdonrd closed this as completed Jun 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants