Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute selectors incorrectly scoped #1282

Closed
ssorallen opened this issue Mar 10, 2015 · 1 comment
Closed

Attribute selectors incorrectly scoped #1282

ssorallen opened this issue Mar 10, 2015 · 1 comment
Assignees

Comments

@ssorallen
Copy link
Contributor

Attribute selectors get incorrect style scoping applied. Consider this example from <core-drawer-panel>:

Source:

core-drawer-panel > core-selector:not(.narrow-layout) [core-drawer-toggle]

Transformed:

core-drawer-panel[style-scope=core-drawer-panel] > core-selector[style-scope=core-drawer-panel]:not(.narrow-layout) [core-drawer-toggle][style-scope=core-drawer-panel]

The [style-scope=core-drawer-panel] at the end is incorrect. It was intended to select any descendant element with the core-drawer-toggle attribute, but they will never have style scopes applied.

A simple attribute selector also becomes scoped:

Source:

[core-drawer-toggle]

Transformed:

[core-drawer-toggle][style-scope=core-drawer-panel]
@ssorallen
Copy link
Contributor Author

Never mind. I misunderstood how ::content works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants