Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to parameterize path to fonts #1674

Closed
RNCRyan opened this issue May 29, 2015 · 3 comments
Closed

Need to parameterize path to fonts #1674

RNCRyan opened this issue May 29, 2015 · 3 comments

Comments

@RNCRyan
Copy link

RNCRyan commented May 29, 2015

Hey,

I'm building a new app at my current employer with Apache Cordova and Polymer. This is being built in Visual Studio 2015, with the goal of deploying it to Android, iOS, and Windows. Exciting stuff.

Except the path to fonts isn't parameterized in the core Polymer controls, and, once installed on a mobile device, my packaged app is failing to retrieve fonts successfully (since it's trying to retrieve the fonts under file://....; not to mention it's trying to make a call over-the-wire, which I want to avoid by serving these fonts locally). Would it be possible to parameterize the path to fonts in the polymer controls? I'd really like to avoid having to diverge from the trunk on the polymer controls.

Thanks! I'm very open to alternatives if there's a better way of solving this problem....

Ryan

@kevinpschaaf
Copy link
Member

Right now, the Roboto font is loaded via the paper-styles element. We'll move this issue there.

There isn't a great way to parameterize the URL used by that stylesheet, since it's not maintained by Polymer (and we probably wouldn't want to fork that).

However, we can probably just fall back to the solution we had in 0.5, which was to separate font-roboto into a separate component imported into paper-styles, so that the end user can just swap in a local-URL based font-roboto implementation for deployment. To be clear, you can do this now, but you'd be overwriting a file that contains more than just the font, whereas the 0.5 font-roboto file only contained this one thing.

@RNCRyan
Copy link
Author

RNCRyan commented Jun 3, 2015

Sounds good; and I agree that sounds like a workable solution. Easy enough to do a pre-build copy on that one file. Thanks!

@tjsavage
Copy link
Contributor

tjsavage commented Jun 5, 2015

auto-moving this issue to PolymerElements/paper-styles#33 and closing this one

@tjsavage tjsavage closed this as completed Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants